Remove the netstandard1.4 build target

It will become increasingly difficult to maintain since the tests can no longer target netcoreapp1.1 since microsoft/vstest#2067
JSkimming · Sep 20, 2019 · 4e3a300 · 4e3a300
1 parent c7c5367
commit 4e3a300
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 29 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -32,27 +32,6 @@ orbs:
           - store_test_results:
               path: ./test/TestResults/output/
 
-      # The --no-restore parameter was added in .NET Core 2, so add a dedicated job for building .NET Core 1.1
-      run-build-1-1:
-        parameters:
-          build-config:
-            description: The build configuration, either Debug or Release.
-            type: string
-        executor:
-          name: dotnet-build-executor
-          tag: "1.1"
-        steps:
-          - checkout
-          - run:
-              name: Restore
-              command: dotnet restore
-          - run:
-              name: Build
-              command: dotnet build -f netcoreapp1.1 -c << parameters.build-config >> ./test/Castle.Core.AsyncInterceptor.Tests/Castle.Core.AsyncInterceptor.Tests.csproj
-          - run:
-              name: Test
-              command: dotnet test --no-build -f netcoreapp1.1 -c << parameters.build-config >> ./test/Castle.Core.AsyncInterceptor.Tests/Castle.Core.AsyncInterceptor.Tests.csproj
-
     executors:
 
       dotnet-build-executor:
@@ -69,12 +48,6 @@ workflows:
     jobs:
       - shellcheck/check:
           name: shellcheck
-      - build/run-build-1-1:
-          name: 1.1 Debug Build
-          build-config: Debug
-      - build/run-build-1-1:
-          name: 1.1 Release Build
-          build-config: Release
       - build/run-build:
           name: 2.1 Debug Build
           image-tag: "2.1"

diff --git a/src/Castle.Core.AsyncInterceptor/Castle.Core.AsyncInterceptor.csproj b/src/Castle.Core.AsyncInterceptor/Castle.Core.AsyncInterceptor.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net45;netstandard1.4;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net45;netstandard2.0</TargetFrameworks>
     <RootNamespace>Castle.DynamicProxy</RootNamespace>
     <LangVersion>latest</LangVersion>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>

diff --git a/test/Castle.Core.AsyncInterceptor.Tests/Castle.Core.AsyncInterceptor.Tests.csproj b/test/Castle.Core.AsyncInterceptor.Tests/Castle.Core.AsyncInterceptor.Tests.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net472;netcoreapp1.1;netcoreapp2.1</TargetFrameworks>
+    <TargetFrameworks>net472;netcoreapp2.1</TargetFrameworks>
     <LangVersion>latest</LangVersion>
     <RootNamespace>Castle.DynamicProxy</RootNamespace>
     <IsPackable>false</IsPackable>