Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units to plotters #136

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Add units to plotters #136

merged 6 commits into from
Sep 13, 2023

Conversation

naik-aakash
Copy link
Collaborator

Closes #135

Updates

  1. Added missing units (eV) to statics and interactive plots when COHP or ICOHP are plotted
  2. Update corresponding test and reference test files

Note: It would be better to merge this PR before others so that I can resolve merge conflicts arising due to changes in this PR

@JaGeo
Copy link
Owner

JaGeo commented Sep 6, 2023

Looks all great:

One thing, the interactive plotter seems to lose its energy label

lobsterpy automatic-plot-ia leads to:

image

lobsterpy automatic-plot-ia --label-resolved adds E-Ef but no (eV)

@JaGeo JaGeo self-assigned this Sep 6, 2023
Copy link
Owner

@JaGeo JaGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comments about my outputs. I am not sure why this is happening but this would need to be fixed before I can merge.

Thanks!

@naik-aakash
Copy link
Collaborator Author

lobsterpy automatic-plot-ia --label-resolved

Thanks for spotting this error. I Have fixed the issue now. It was partly a limitation of plotly not being able to render text when added to the latex labels. It should work fine now . Will push the changes in few minutes

@naik-aakash
Copy link
Collaborator Author

Fixed output
image

@naik-aakash
Copy link
Collaborator Author

I hope now it could be merged 😃

@JaGeo
Copy link
Owner

JaGeo commented Sep 13, 2023

Unfortunately, lobsterpy automatic-plot-ia --label-resolved doesn't work anymore... Could you check?

@JaGeo
Copy link
Owner

JaGeo commented Sep 13, 2023

It also stopped working in the master branch. Not sure why and when.

@JaGeo JaGeo merged commit b78ba40 into JaGeo:main Sep 13, 2023
@naik-aakash naik-aakash deleted the add_units_to_plotters branch October 28, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add units to plotters
2 participants