snakecase key names of calc quality summary dict #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaGeo
approved these changes
Sep 26, 2023
|
Great. Fine :). I will merge it. Should I release another version soon? |
Unm let me work a bit further on the atomate2 data generation extension. Will let you know soon maybe by tomorrow :-) (just want to make sure if nothing more pops up) Yes we will need a new release soon with this new change 😅 |
|
Yeah, this is not much work 😅. Just ping me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JaGeo, I fixed the key names in calc quality summary dict which did not follow snakecase convention.
Necessary for cleaner atomate2 data generation integration
Closes #156