Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing matplotlib style file in package installation #159

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Fix missing matplotlib style file in package installation #159

merged 2 commits into from
Oct 5, 2023

Conversation

naik-aakash
Copy link
Collaborator

@naik-aakash naik-aakash commented Sep 28, 2023 •
edited
Loading

  1. Added the missing setup tools line which now includes the matplotlib style file necessary for plotting
  2. Updated testing workflow to make static install and avoid such bugs in future

Closes #158

@naik-aakash
Update pyproject.toml
7a70c2e 
Added the missing setup tools line which now includes the matplotlib style file necessary for plotting
QuantumChemist
QuantumChemist reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@QuantumChemist QuantumChemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything works fine with this :)

@naik-aakash
Copy link
Collaborator Author

everything works fine with this :)

Thanks @QuantumChemist for feedback and pointing out this bug

@naik-aakash
Copy link
Collaborator Author

Hi @JaGeo , this PR is ready to be merged 😄

@naik-aakash naik-aakash changed the title Update pyproject.toml Fix missing matplotlib style file in package installation Sep 28, 2023
@naik-aakash naik-aakash added the bug Something isn't working label Sep 28, 2023
@naik-aakash naik-aakash self-assigned this Sep 28, 2023
@naik-aakash
update test workflow
79543ff 
Make static instal for testing
@JaGeo JaGeo merged commit df26c61 into JaGeo:main Oct 5, 2023
@naik-aakash naik-aakash deleted the fix_mpstyle_not_included branch October 28, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumChemist QuantumChemist QuantumChemist left review comments

@JaGeo JaGeo JaGeo approved these changes

Assignees

@naik-aakash naik-aakash

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plotting DOS or COXX not possible with latest lobsterpy version
3 participants
@naik-aakash @JaGeo @QuantumChemist