snakecase whichbonds arg and update tests #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JaGeo, PR should be ready for review 😄 |
JaGeo
requested changes
Sep 29, 2023
There was a problem hiding this comment.
@naik-aakash Thanks! I think I would recommend thinking about the difference between the parameter name and a string. Usage of snake case is only recommended for the parameters. I would not change "cation-anion" as this is a natural way to write it.
|
Hi @JaGeo, if this is fine, can you please merge it as well? The only change is which_bonds arg in snake case and rest is same as before 😃 |
JaGeo
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160
Changes