Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace get_anion_types with anion_types #174

Merged
merged 3 commits into from
Nov 8, 2023
Merged

replace get_anion_types with anion_types #174

merged 3 commits into from
Nov 8, 2023

Conversation

naik-aakash
Copy link
Collaborator

Changes

  • replaced deprecated get_anion_types with anion_types

Closes #173

@naik-aakash
Copy link
Collaborator Author

@JaGeo , could be merged right away I think. Hope it did not break any tests

@naik-aakash
Copy link
Collaborator Author

This PR could also be merged

@JaGeo JaGeo merged commit 48b8d5a into JaGeo:main Nov 8, 2023
22 checks passed
@naik-aakash naik-aakash deleted the remove_deprecated_attribute branch June 20, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaGeo JaGeo JaGeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"get_anion_types is deprecated; use anion_types in pymatgen.io.lobster.lobsterenv instead."
2 participants
@naik-aakash @JaGeo