Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add POSCAR.lobster support in featurizer #186

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

naik-aakash
Copy link
Collaborator

Changes

  1. Checks if POSCAR.lobster exists instead of POSCAR then use it as default structure file

@naik-aakash
Copy link
Collaborator Author

Hi @JaGeo, I think this is all that is needed.

In CLI, already we have the option to switch structure files, so do we such manupulation there as well or I mention this thing in the documentation and it should be enough? (I feel mentioning it in documentation is enough, but wanted your opinion on this)

@JaGeo JaGeo merged commit 1365944 into JaGeo:main Nov 21, 2023
23 checks passed
@JaGeo
Copy link
Owner

JaGeo commented Nov 21, 2023

Just mention it in the documentation. Thanks!

@naik-aakash naik-aakash deleted the lobster_5_support branch June 20, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants