Set python version stricter limit #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaGeo
reviewed
Feb 7, 2024
| @@ -1605,7 +1605,7 @@ def get_lobster_calc_quality_summary( | |||
|
|
|||
| dos_lobster = doscar_lobster.completedos | |||
|
|
|||
| vasprun = Vasprun(path_to_vasprun) | |||
| vasprun = Vasprun(path_to_vasprun, parse_potcar_file=False) | |||
There was a problem hiding this comment.
This works with the latest pymatgen version, right?
There was a problem hiding this comment.
Yes, this change was necessary coz of latest pymatgen
JaGeo
approved these changes
Feb 7, 2024
|
Can I merge? |
|
Hi @JaGeo , I think this should fix it. We need to make another release though |
naik-aakash
changed the title
Yes 😄 |
We will make the release after the review or is the pymatgen issue critical? |
Its critical for calc quality summary feature only. Maybe better to release it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221