File path handling in featurizer module #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… structure file handling in featurizer module.
…ge_type handling in BatchSummaryFeaturizer.
…re path handling.
…to display actual possible parameter values.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 97.47% 97.70% +0.23%
==========================================
Files 11 12 +1
Lines 2848 2698 -150
==========================================
- Hits 2776 2636 -140
+ Misses 72 62 -10 ☔ View full report in Codecov by Sentry. |
… into structure_path Pulling other merges from upstream repo.
|
Thanks @kaueltzen ! I think this can be merged as well if there are not any comments @JaGeo 😄 |
JaGeo
approved these changes
Feb 26, 2024
JaGeo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #229 .
File path handling in featurizer module is now done in two separate functions in utils.py.
Also did some clean-ups and added parameter checking for BatchSummaryFeaturizer.