Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli bug, cleanup and enhancement #256

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Fix cli bug, cleanup and enhancement #256

merged 2 commits into from
Mar 12, 2024

Conversation

naik-aakash
Copy link
Collaborator

@naik-aakash naik-aakash commented Mar 12, 2024

Closes #254

Todo

  • [×] Add test with poscar.lobster
  • [×] Add option for spin-polarized plots in cli for automatic analysis

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.41%. Comparing base (320fec0) to head (275168d).
Report is 1 commits behind head on main.

Files Patch % Lines
lobsterpy/cli.py 95.91% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   97.51%   97.41%   -0.11%     
==========================================
  Files          12       12              
  Lines        2700     2669      -31     
==========================================
- Hits         2633     2600      -33     
- Misses         67       69       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaGeo
Copy link
Owner

JaGeo commented Mar 12, 2024

I will test it tonight when you say it is okay ;). Then, I will release a new version.

Copy link
Owner

@JaGeo JaGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine!

@JaGeo JaGeo merged commit 522ee59 into main Mar 12, 2024
25 of 26 checks passed
@naik-aakash naik-aakash deleted the fix_cli_poscar.lobster branch March 13, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lobsterpy does not work if only POSCAR.lobster exists
2 participants