-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 support #282
Python 3.12 support #282
Conversation
@naik-aakash I deactivated flake8 for now. There seems to be an issue with the installation or a bug. |
Hi @JaGeo , you mean flake8 fails on python 3.12 ? |
Yes, not working. I also cannot fix this very last error. I am not sure if they really drop support for asserting to a Bool? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 97.19% 97.37% +0.18%
==========================================
Files 12 12
Lines 2672 2671 -1
==========================================
+ Hits 2597 2601 +4
+ Misses 75 70 -5 ☔ View full report in Codecov by Sentry. |
@naik-aakash I did it but we have to update "get_lobster_calc_quality_summary" as it raises many warnings. |
But this is what was expected to raise warnings if certain criteria is not met. Will think of other ways to alert users. At this time I don't have any other idea to do the same. And that particular test was written to check for all warnings specifically. In actual case, this won't happen |
No, please check it out. There are warnings about how you test if a value is None. This is only a problem in newer Python versions or during the actions |
No description provided.