Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev ubuntu 24.04 lts #140

Merged
merged 6 commits into from
Aug 10, 2024
Merged

Dev ubuntu 24.04 lts #140

merged 6 commits into from
Aug 10, 2024

Conversation

jaruizra
Copy link

@jaruizra jaruizra commented Aug 7, 2024

Pull Request

Description

  • Removed Ubuntu's default Rust installation to ensure all scripts use the latest Rust version by correctly sourcing the new installation.
  • Disabled logging for the sddm package installation to fix related installation issues, resolving issue sddm Installation Menu Unresponsive to Arrow Key Inputs #2.
  • Enabled source repositories to resolve errors when installing dependencies for wlroots.
  • Fixed compilation errors for asusctl and supergfxctl by ensuring the correct Rust version is used.
  • Addressed indentation and coding style issues in installation scripts for better readability and adherence to best programming practices.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I want to add something in Debian-Hyprland wiki.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Additional context

If issue #2 is resolved, the documentation should be updated to reflect that sddm can be installed without issues. It has been successfully tested on both VMware and physical machines.

@JaKooLit
Copy link
Owner

Im gonna merge this for now but wont be pushing to Main.

Thanks alot

I will test this once Im at home. Estimated by the End of this month

@JaKooLit JaKooLit merged commit e86b78b into JaKooLit:dev-Ubuntu-24.04-LTS Aug 10, 2024
@jaruizra jaruizra deleted the dev-Ubuntu-24.04-LTS branch August 10, 2024 14:18
@jaruizra
Copy link
Author

Don’t worry!

I’ve really been enjoying your project so far.

By the way, I’ve been reviewing some of the open issues, and they all seem to be related to specific user cases rather than widespread problems. Everything appears to be working properly.

I noticed from your post that Debian has added the Hyprland package. If you need any help with scripts related to Ubuntu/Debian, feel free to reach out, I’d be glad to assist! 👍

@JaKooLit
Copy link
Owner

JaKooLit commented Aug 10, 2024

Don’t worry!

I’ve really been enjoying your project so far.

By the way, I’ve been reviewing some of the open issues, and they all seem to be related to specific user cases rather than widespread problems. Everything appears to be working properly.

I noticed from your post that Debian has added the Hyprland package. If you need any help with scripts related to Ubuntu/Debian, feel free to reach out, I’d be glad to assist! 👍

Its fine. I can change and edit codes with no issues, however, I need to try it first my self. But, I cannot test now since I am busy with work plus I have a very limited data.

and yes, most of the issues are just user cases not widespread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants