Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with removing elements to a group (subgroup). #10374

Closed
2 tasks done
mlep opened this issue Sep 12, 2023 · 1 comment · Fixed by #10408
Closed
2 tasks done

Problem with removing elements to a group (subgroup). #10374

mlep opened this issue Sep 12, 2023 · 1 comment · Fixed by #10408
Labels
component: groups

Comments

@mlep
Copy link
Contributor

mlep commented Sep 12, 2023

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.11--2023-09-07--29f5cae Linux 6.1.0-5-amd64 amd64 Java 21-internal JavaFX 20+19

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

While drag-and-drop allows for adding entries to a (sub)group, there is no such easy feature for removing entries from a group: removal of entries from a group has an undesirable behavior.

Here is the description of the step leading to the unwanted behavior:

  1. Open https://github.com/JabRef/jabref/blob/main/src/test/resources/testbib/jabref-authors.bib
  2. Select the group "All entries"
  3. Select the entry by Kirk (for example). It is included in the group "By rating", and you want to remove it from there.
  4. Right-click on the group "By rating" and select the menu "Remove selected entries from this group"
  5. The entry is removed from the subgroup
  6. But, now, the group "By rating" is selected, and the entry Kirk is not selected anymore (another entry is selected).

I believe step 6 should not happen: the group "By rating" should not be selected. Instead, the group "All entries" and the entry "Kirk" should remain selected.

Related to #10317, but for removing elements from a (sub)group.

Appendix

...

Log File 
Paste an excerpt of your log file here
Siedlerchr added a commit that referenced this issue Sep 24, 2023
@Siedlerchr
Fix adding and removing selected entries to group context menu
2258dc7 
Fixes #10403
Fixes #10317
Fixes #10374
@Siedlerchr Siedlerchr mentioned this issue Sep 24, 2023
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 25, 2023
@Siedlerchr
Fix adding and removing selected entries to group context menu (#10408)
b06e443 
* Fix adding and removing selected entries to group context menu

Fixes #10403
Fixes #10317
Fixes #10374

* remove globals
fix checkstyle
@mlep
Copy link
Contributor Author

mlep commented Oct 19, 2023

I can confirm the issue is solved in JabRef 5.11--2023-10-18--f8cbda5
Thank you @Siedlerchr

(and sorry for the delay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: groups
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix adding and removing selected entries to group context menu JabRef/jabref
2 participants
@Siedlerchr @mlep