Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings in edit fields not updating to match the source fields #2888

Closed
wujastyk opened this issue Jun 5, 2017 · 11 comments
Closed

Strings in edit fields not updating to match the source fields #2888

wujastyk opened this issue Jun 5, 2017 · 11 comments
Assignees
Labels
component: entry-editor [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Milestone

Comments

@wujastyk
Copy link

wujastyk commented Jun 5, 2017

JabRef version
JabRef 4.0.0-dev--snapshot--2017-05-31--master--c9566c2a9
Linux 4.10.0-21-generic amd64
Java 1.8.0_131

Steps to reproduce:

  1. I edit a field, e.g., shorthand (which I've added to the "Required Fields" tab)
  2. I go to the "{} biblatex source" tab and edit the shorthand field
  3. Returning to the "Required Fields" tab, the shorthand field is not updated.

screenshot from 2017-06-05 09-18-42

screenshot from 2017-06-05 09-18-55

@tobiasdiez tobiasdiez added [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs component: entry-editor labels Jun 5, 2017
@tobiasdiez tobiasdiez added this to the v4.0 milestone Jun 5, 2017
@Siedlerchr
Copy link
Member

When you change to another entry and then change back, the update is applied and the field content is visible

@Siedlerchr
Copy link
Member

I think to solve this, wee need a Binding between codeArea.textProperty() and entry.toString() or a field which represents the whole BibEntry as String.

@koppor
Copy link
Member

koppor commented Jul 11, 2017

Refs #2946

@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks!

@wujastyk
Copy link
Author

wujastyk commented Jul 13, 2017 via email

@wujastyk
Copy link
Author

wujastyk commented Jul 14, 2017

Sorry, this story isn't over after all.

Edits to "biblatex source" are now correctly displayed in "required fields". But not vice-versa. Edits to "required fields" are not updated in "biblatex source."

Dominik

Using

JabRef 4.0.0-dev--snapshot--2017-07-13--master--504646403
Linux 4.8.0-58-generic amd64
Java 1.8.0_131

@lenhard
Copy link
Member

lenhard commented Jul 18, 2017

@wujastyk We've attempted another fix and source field should now also be updated. Could you please try out the newest development snapshot and report back if it works?

@lenhard lenhard closed this as completed Jul 18, 2017
@wujastyk
Copy link
Author

wujastyk commented Jul 18, 2017

Seems good, after simple tests. Thank you!!!

JabRef 4.0.0-dev--snapshot--2017-07-18--master--7d31fa28c
Linux 4.8.0-58-generic amd64
Java 1.8.0_131

@wujastyk
Copy link
Author

Sorry to say, but further work today shows that this problem persists.

I've been working with this record:

@Article{10.2307/40849180,
ISSN = {09353518, 21968071},
URL = {http://www.jstor.org/stable/40849180},
author = {Gerd Carling},
journal = {Historische Sprachforschung / Historical Linguistics},
number = {1},
pages = {75-95},
publisher = {Vandenhoeck & Ruprecht (GmbH & Co. KG)},
title = {New look at the Tocharian B medical manuscript IOL Toch 306 (Stein Ch.00316. a2) of the British Library - Oriental and India Office Collections},
volume = {116},
date = {2003}
}

In the "Required fields" tab I change the title to

New Look at the {Tocharian B} Medical Manuscript {IOL Toch 306 (Stein Ch.00316. a2)} of the {British Library} - {Oriental and India Office} Collections

and that change isn't saved or reflected in "biblatex source".

JabRef 4.0.0-dev--snapshot--2017-07-18--master--7d31fa28c
Linux 4.8.0-58-generic amd64
Java 1.8.0_131

@lenhard
Copy link
Member

lenhard commented Jul 19, 2017

@wujastyk That's interesting, because the dev-snapshot you reported (7d31fa2) is the one directly before my fix with regards to the source panel was merged. In that the version, the bug actually shouldn't have been fixed (yet). Could you try again with a new version from http://builds.jabref.org/master/ ?

@wujastyk
Copy link
Author

wujastyk commented Jul 19, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: entry-editor [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

No branches or pull requests

5 participants