Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when adding new aux group #10352

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Fix NPE when adding new aux group #10352

merged 3 commits into from
Sep 8, 2023

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Sep 8, 2023

Fixes #10350

Init viewModel in initializing method, not in ctor as injected are not yet present in ctor

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Fixes #10350

Init viewModel in initializing method, not in ctor as injected are not yet present in ctor
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor
Copy link
Member

koppor commented Sep 8, 2023

I get following exception - related?

ERROR: Error while watching for changes: java.lang.NumberFormatException: For input string: "C:/git-repositories/koppor/tugboat2023-jabref/tb137kopp-jabref.aux"
        at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
        at java.base/java.lang.Integer.parseInt(Integer.java:665)
        at java.base/java.lang.Integer.parseInt(Integer.java:781)
        at [email protected]/org.jabref.logic.importer.util.GroupsParser.texGroupFromString(GroupsParser.java:129)

@Siedlerchr
Copy link
Member Author

I get following exception - related?

ERROR: Error while watching for changes: java.lang.NumberFormatException: For input string: "C:/git-repositories/koppor/tugboat2023-jabref/tb137kopp-jabref.aux"
        at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
        at java.base/java.lang.Integer.parseInt(Integer.java:665)
        at java.base/java.lang.Integer.parseInt(Integer.java:781)
        at [email protected]/org.jabref.logic.importer.util.GroupsParser.texGroupFromString(GroupsParser.java:129)

#9776

@Siedlerchr Siedlerchr merged commit 5199de3 into main Sep 8, 2023
@Siedlerchr Siedlerchr deleted the fixNpeInAuxGroupAdding branch September 8, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught exception when adding group from cited references
2 participants