Fix authorsAlpha #11614

subhramit · 2024-08-12T19:26:05Z

Fix authorsAlpha

[Auxiliary PR, required for the GSoC '24 CSL4LibreOffice project]

Fix for the function authorsAlpha in BracketedPattern which returns author representation for the purpose of alphanumeric styles.
Adapted for the purpose of DIN 1505-02.
Changes:

Max authors before "exceed limit" is 4.
No appending "+" if exceeded
For a single author, (maximum) first 4 letters of the author name are taken instead of 3.

Investigation ref. #11577 and issue subhramit#17

References:
https://forums.zotero.org/discussion/12239/style-request-lecture-notes-in-informatics-lni-from-the-germany-computer-science-society
https://forums.zotero.org/discussion/82660/format-din-1505-2-alphanumeric-german-standard-superseded-by-iso-690
https://forums.zotero.org/discussion/82631/problem-with-citation-style-din-1505-2-alphanumeric-german-and-word-integration
Template attached to first link: ISSS-word-template.docx

Mandatory checks

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor · 2024-08-12T19:30:27Z

The authorsAlpha implementation is aligned with "GI e.V."'s biblatexs style: https://github.com/gi-ev/biblatex-lni

Output:

LaTeX-Source: https://github.com/gi-ev/biblatex-lni/blob/main/basic-test-en.tex

If we change something in the behavior, all things need to be aligned.

The "ultimate" truth is the Word template at https://gi.de/service/publikationen/lni. But I remember, that also does not cover all cases.

koppor · 2024-08-12T19:31:27Z

The current test cases are:

    static Stream<Arguments> authorsAlpha() {
        return Stream.of(
                Arguments.of("A+", "Alexander Artemenko and others"),
                Arguments.of("A+", "Aachen and others"),
                Arguments.of("AB+", "Aachen and Berlin and others"),
                Arguments.of("ABC+", "Aachen and Berlin and Chemnitz and others"),
                // FIXME: Arguments.of("Aach", "Aachen"),
                Arguments.of("AB", "Aachen and Berlin"),
                Arguments.of("ABC", "Aachen and Berlin and Chemnitz"),
                Arguments.of("ABCD", "Aachen and Berlin and Chemnitz and Düsseldorf"),
                Arguments.of("ABC+", "Aachen and Berlin and Chemnitz and Düsseldorf and others"),
                Arguments.of("ABC+", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen"),
                Arguments.of("ABC+", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen and others"));
    }

If the test case do not fail at this PR, you found a simpler implementation.

koppor · 2024-08-12T19:33:20Z

The update does not support "and others" any more:

subhramit · 2024-08-12T19:35:40Z

The current test cases are:
Arguments.of("ABC+", "Aachen and Berlin and Chemnitz and Düsseldorf and others"),
Arguments.of("ABC+", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen"),
Arguments.of("ABC+", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen and others"));
}
If the test case do not fail at this PR, you found a simpler implementation.

ABC+ won't work with this one. I had removed the + for DIn 1505-02.
Also, ABC+ implies three max authors represented, while the PR changes it to 4 (ABCD and no +)

koppor · 2024-08-12T19:47:26Z

Examples from the template:

[AB00]	Abel, K.; Bibel, U.: Formatierungsrichtlinien für Tagungsbände. Format-Verlag, Bonn, 2000.
[ABC01]	Abraham, N.; Bibel, U.: Corleone, P.: Formatting Contributions for Proceedings. In (Glück, H.I. ed.): Proc. 7th Int. Conf. on Formatting of Workshop-Proceedings, New York 1999. Noah & Sons, San Francisco, pp. 46-53, 2001.
[An14] 	Anteil an Frauen in der Informatik. Statistics Worldwide, 2014.
[Az09]	Azubi, L. et.al.: Die Fußnote in LNI-Bänden. In (Glück, H. I., ed.): Formatierung 2009. LNI 999, Format-Verlag, Bonn, pp. 135-162, 2009.
[Ez10]	Ezgarani, O.: The Magic Format – Your Way to Pretty Books. Noah & Sons, 2010.
[GI14]	GI, Gesellschaft für Informatik e.V., [www.gi-ev.at](http://www.gi-ev.at/), accessed: 24/12/2014.
[Gl09]	Glück, H. I.: Formatierung leicht gemacht. Formatierungsjournal 11/09, pp. 23-27, 2009.
[Wa14a] 	Wasser, K.; Feuer, H.; Erde, R.; Licht, H.: Essenzen der Informatik. Verlag Formvoll, 2014.
[Wa14b] 	Wasser, K.; Feuer, H.; Erde, R.; Licht, H.: Ganz neue Essenzen der Informatik im selben Jahr. Format-Verlag, 2014.

koppor · 2024-08-12T19:50:17Z

After double check with the LNI guidelines, it is OK to remove the +.

For proper software engineering:

Add support for handling "and others" (no "+" but two letters of the first last name)
Adapt existing test cases
Add LNI test cases to test cases (Fix authorsAlpha #11614 (comment))

subhramit · 2024-08-12T20:55:10Z

Sorry, I mis-clicked on edit instead of reply.
@koppor
Could you clarify a bit more on:

Add support for handling "and others" (no "+" but two letters of the first last name)

Meaning - if there is "and others" in the title, what should be done differently? Should it be treated as if we ignore "and others"? First last name of whom? First author? All authors? And when? (is the two letters thing related to/valid only in the case of "and others"?)
https://forums.zotero.org/discussion/82631/problem-with-citation-style-din-1505-2-alphanumeric-german-and-word-integration has the following:

That is, till three authors, a total of 4 letters would be filled, depending on how many "extra authors" are there after 1.

koppor · 2024-08-12T21:01:59Z

I thought, the rules for "exceeding" are clear.

Four letters of the first last name.

Treat and others as exceeding.

koppor · 2024-08-12T21:05:03Z

forums.zotero.org/discussion/82631/problem-with-citation-style-din-1505-2-alphanumeric-german-and-word-integration has

A random dude in the net writing something in a comment without trustable sources. - Moreover, his examples lead to different results as shown at #11614 (comment).

I think, the pattern the linuxguy said is supported by JabRef too, but I don't find at https://docs.jabref.org/setup/citationkeypatterns

subhramit · 2024-08-12T22:26:07Z

Side note: Also required for PR-D of CSL4LibreOffice.

subhramit · 2024-08-12T22:48:12Z

After double check with the LNI guidelines, it is OK to remove the +.

For proper software engineering:

Add support for handling "and others" (no "+" but two letters of the first last name)

Can you tell me if the following expected outputs are correct/desired?:

Case 1:

Arguments.of("Al", "Alexander Artemenko and others"),
                Arguments.of("Aa", "Aachen and others"),
                Arguments.of("Aa", "Aachen and Berlin and others"),
                Arguments.of("Aa", "Aachen and Berlin and Chemnitz and others"),
                Arguments.of("AB", "Aachen and Berlin"),
                Arguments.of("ABC", "Aachen and Berlin and Chemnitz"),
                Arguments.of("ABCD", "Aachen and Berlin and Chemnitz and Düsseldorf"),
                Arguments.of("Aa", "Aachen and Berlin and Chemnitz and Düsseldorf and others"),
                Arguments.of("ABCD", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen"),
                Arguments.of("Aa", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen and others"));

Case 2:

Arguments.of("Al", "Alexander Artemenko and others"),
                Arguments.of("Aa", "Aachen and others"),
                Arguments.of("AaBe", "Aachen and Berlin and others"),
                Arguments.of("AaBeCh", "Aachen and Berlin and Chemnitz and others"),
                Arguments.of("AB", "Aachen and Berlin"),
                Arguments.of("ABC", "Aachen and Berlin and Chemnitz"),
                Arguments.of("ABCD", "Aachen and Berlin and Chemnitz and Düsseldorf"),
                Arguments.of("AaBeChDü", "Aachen and Berlin and Chemnitz and Düsseldorf and others"),
                Arguments.of("ABCD", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen"),
                Arguments.of("AaBeChDü", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen and others"));

Case 3:

Arguments.of("Al", "Alexander Artemenko and others"),
                Arguments.of("Aa", "Aachen and others"),
                Arguments.of("AaB", "Aachen and Berlin and others"),
                Arguments.of("AaBC", "Aachen and Berlin and Chemnitz and others"),
                Arguments.of("AB", "Aachen and Berlin"),
                Arguments.of("ABC", "Aachen and Berlin and Chemnitz"),
                Arguments.of("ABCD", "Aachen and Berlin and Chemnitz and Düsseldorf"),
                Arguments.of("AaBC", "Aachen and Berlin and Chemnitz and Düsseldorf and others"),
                Arguments.of("ABCD", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen"),
                Arguments.of("AaBC", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen and others"));

or anything else?

subhramit · 2024-08-12T22:57:44Z

I thought, the rules for "exceeding" are clear.

Four letters of the first last name.

Treat and others as exceeding.

In the comment stating requirements, you mentioned two letters of the first last name instead of four (as mentioned here). I would request more clarification with examples for "and others" case with multiple authors (refer the cases above).

koppor · 2024-08-13T06:46:01Z

I thought, the rules for "exceeding" are clear.

Four letters of the first last name.

Treat and others as exceeding.

In the comment stating requirements, you mentioned two letters of the first last name instead of four (as mentioned here). I would request more clarification with examples for "and others" case with multiple authors (refer the cases above).

I take #11614 (comment) as ground truth. They use two letters. We follow that.

With "exceeding" I meant, it exceeds maximum number of authors. Thus, "and others" means five authors present. Thus, it is case 1.

subhramit · 2024-08-13T07:46:43Z

Also, the last two examples from the template have:

[Wa14a] Wasser, K.; Feuer, H.; Erde, R.; Licht, H.: Essenzen der Informatik. Verlag Formvoll, 2014.
[Wa14b] Wasser, K.; Feuer, H.; Erde, R.; Licht, H.: Ganz neue Essenzen der Informatik im selben Jahr. Format-Verlag, 2014.

[Wa14a] and [Wa14b] imply there has to be an alphabetical counter that gets auto-incremented if two instances of authors are exactly the same but the papers are different. CSL uses itemDataProvider, which automatically supplies numbers, which are then taken care of by reference marks. We would need a similar system for this - but also that detects difference only in papers with the same authors. Furthermore, the letter has to be appended after the "Year" part, which is not handled by authorsAlpha.

Is this a compulsory requirement for this PR? Or should we just add the other cases to the test case and keep this as an edge case and try to think of it later?

subhramit · 2024-08-13T07:49:12Z

Also, the last two examples from the template have:
[Wa14a] Wasser, K.; Feuer, H.; Erde, R.; Licht, H.: Essenzen der Informatik. Verlag Formvoll, 2014.
[Wa14b] Wasser, K.; Feuer, H.; Erde, R.; Licht, H.: Ganz neue Essenzen der Informatik im selben Jahr. Format-Verlag, 2014.
[Wa14a] and [Wa14b] imply there has to be an alphabetical counter that gets auto-incremented if two instances of authors are exactly the same but the papers are different. CSL uses itemDataProvider, which automatically supplies numbers, which are then taken care of by reference marks. We would need a similar system for this - but also that detects difference only in papers with the same authors. Furthermore, the letter has to be appended after the "Year" part, which is not handled by authorsAlpha.

Is this a compulsory requirement for this PR? Or should we just add the other cases to the test case and keep this as an edge case and try to think of it later?

This is also slightly contradictory, as it does not exceed the maximum number of authors (=4), yet uses the first author's two characters only instead of the first character from all 4. (At least it is well-established for DNI everywhere that there can be 4 authors maximum represented).

subhramit · 2024-08-13T07:58:58Z

Also, the last two examples from the template have:
[Wa14a] Wasser, K.; Feuer, H.; Erde, R.; Licht, H.: Essenzen der Informatik. Verlag Formvoll, 2014.
[Wa14b] Wasser, K.; Feuer, H.; Erde, R.; Licht, H.: Ganz neue Essenzen der Informatik im selben Jahr. Format-Verlag, 2014.
[Wa14a] and [Wa14b] imply there has to be an alphabetical counter that gets auto-incremented if two instances of authors are exactly the same but the papers are different. CSL uses itemDataProvider, which automatically supplies numbers, which are then taken care of by reference marks. We would need a similar system for this - but also that detects difference only in papers with the same authors. Furthermore, the letter has to be appended after the "Year" part, which is not handled by authorsAlpha.

Is this a compulsory requirement for this PR? Or should we just add the other cases to the test case and keep this as an edge case and try to think of it later?

Okay, after some thought, I am skipping these last two cases. Reason: It would also require "future insight" - if the same authors are going to be cited again in future, we have to append an "a" at the end of the first instance right away. Since this will not be possible, the only way is to have targeted editing of the citations as more such entries are cited, which is a hard problem again (auto-refreshment of old citations).

koppor · 2024-08-13T08:39:17Z

Is this a compulsory requirement for this PR? Or should we just add the other cases to the test case and keep this as an edge case and try to think of it later?

One by one. Keep focus. Divide and conquer.

"Just" fix authorsAlpha.

JabRef has this functionality internally already. Check the preferences of the citation key generator.

Maybe, it can be reused. Maybe only if a complete bibdatabasecontext is available. Then, the code needs to be refactored.

subhramit · 2024-08-13T15:22:18Z

@koppor please see if the changes are fine.
Only case I did not handle is:

[An14] 	Anteil an Frauen in der Informatik. Statistics Worldwide, 2014.

(since it did not have any author name in it, I figured by translating, nor commas that would separate a name like GI, Gesellschaft für Informatik e.V., which is handled). This seems to be out of scope for "authorsAlpha".

Is this OK for now?

Also added one-to-one test cases for an auxiliary function I extracted to get last name, it was common for both single author and "and others" case.

koppor · 2024-08-13T22:59:58Z

The other day, @Siedlerchr too suggested that it is easier for maintainers to review and merge PRs if we branch off upstream/main. I was thinking of cloning directly and adding a branch from main, but I was wondering if contributors can safely do that as it was missing from devdocs (devdocs.jabref.org/contributing.html#understanding-the-basics-of-code-contributions).

I highlight the current text regarding the branches.

I think, points 2 and 3 need to be merged. And refined with the two git commands.

If it's just these two commands, I will file a PR adding it to the devdocs. Should we "prefer" new contributors to branch from main as well? Or should it just be mentioned as Choice 1/ Choice 2 in the docs?

There is no choice. It is always upstream/main. I have no clue, what some other choice could be...

subhramit · 2024-08-13T23:02:25Z

There is no choice. It is always upstream/main. I have no clue, what some other choice could be...

My bad, that was unclear. I meant branching from the fork (origin) vs the main repo (upstream). I also saw Loay mention that builds are generated for branches from upstream.

subhramit · 2024-08-13T23:54:45Z

Summary of last two commits (resolution of failing unit tests):

Removed "+" from the end of expected strings in CitationKeyGeneratorTest for the tests involving authorsAlpha.
Adapted expected authorsAlpha output "vdAal" to "Aa" for input "Wil van der Aalst" and so on, as per the convention we are following this PR onwards.
Changed number of expected characters from authorsAlpha output e.g. from "New" to "Ne" for input "Isaac Newton".
Similar changes in BracketedPatternTest.
[Additional] Removed Exceptions that were not being thrown from tests in AbstractCitationKeyPatternsTest and BibEntryTest along the way.

koppor · 2024-08-15T22:58:21Z

src/test/java/org/jabref/logic/citationkeypattern/BracketedPatternTest.java

-                Arguments.of("ABC+", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen"),
-                Arguments.of("ABC+", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen and others"));
+                Arguments.of("Aa", "Aachen and Berlin and Chemnitz and Düsseldorf and others"),
+                Arguments.of("ABCD", "Aachen and Berlin and Chemnitz and Düsseldorf and Essen"),


This does exceed 4 authors, why is this not Aa?

As per our discussion, we would do that if there is "and others". (Refer Case "1"). Furthermore, this has been established ever since we started talking about DIN. I can do only the first author's two letters of last name in case of exceeding authors but note that everywhere I have looked, in case of exceeding authors (and no "and others"), the abbreviation of first four authors are taken.
You can try citing 10.3945/ajcn.111.023457 using citationmachine as well: https://www.citationmachine.net/bibliographies/a446c586-d900-4583-a249-72d7b9bc0b52

Besides the LNI template: #11614 (comment)

We need to setup a minimal latex+bibtex document with authorsalpha with the test cases and see what that returns.

koppor · 2024-08-15T23:00:33Z

src/main/java/org/jabref/logic/citationkeypattern/BracketedPattern.java

+    static String getLastName(Author author) {
+        String[] nameParts = author.getNamePrefixAndFamilyName()
+                                   .replaceAll("\\s+", " ")
+                                   .trim()
+                                   .split(" ");
+        return nameParts[nameParts.length - 1];
+    }


Why can't you use org.jabref.model.entry.Author#getFamilyName?

…rsAlpha

koppor · 2024-08-16T06:06:11Z

@subhramit It is so great to see that now two persons (you and me) are in the context of authorsalpha.

Can you add a test for institutions?

In BibTeX, they are written as author = {{Gesellschaft für Informatik e.V.}}. In JabRef then {Gesellschaft für Informatik e.V.}` (because the outer braces are removed while reading (and added while writing)).

I am curious whether the thing works there, too.

koppor · 2024-08-16T08:24:28Z

It is good enough for now.

What I understood:

DIN is outdated
DIN is requested in the Zotero forum because of LNI use
LNI publishes its guidelines
LNI differs from DIN in some cases

What I miss:

other appearances in the wild of that style (besides "my" scientific-thesis-tempalte: https://github.com/latextemplates/scientific-thesis-template
minimal example using bibtex authorsalpha
a structured markdown file where the sources of the decisions are listed (and also a TL;DR summary is given) -- "keygenerators.md" in folder https://github.com/JabRef/jabref/tree/main/docs/code-howtos is a good place

Reason for the last point: We exchange information at multiple different places (which makes it scattered), but the core knowledge is not condensed. What if someone looks into that in one year - and if none of us both is available? --> Documentaiton enables asynchronous work.

Follow-up TODOs:

Collect knowledge in keygenerators.md. (New PR!)
Create .tex and .bib file for authorsalpha and the different cases (New PR)
Find usages of authorsalpha in the wild. (Add it to keygenerators.md. (New PR)
check institutions - example: author = {{Apache Foundation}}. It is OK if it fails, we just need to know and then think of solutions. For BibLaTeX, there is the feature label = {AF}. (add result to keygenerators.md - New PR). Add test case for that. Maybe commented out or marked with // TODO ...

koppor · 2024-08-16T08:29:47Z

src/main/java/org/jabref/logic/citationkeypattern/BracketedPattern.java

-    static String getLastName(Author author) {
-        String[] nameParts = author.getNamePrefixAndFamilyName()
-                                   .replaceAll("\\s+", " ")
-                                   .trim()
-                                   .split(" ");
-        return nameParts[nameParts.length - 1];
-    }


Code hint - if you encounter a similar case in the future, there is a more intuitive code IMHO:

https://www.w3schools.com/java/ref_string_lastindexof.asp

int pos = string.lastIndexOf(" "); String result = string.substr(pos +1);

subhramit · 2024-08-16T08:29:59Z

It is good enough for now.

What I understood:

DIN is outdated

DIN is requested in the Zotero forum because of LNI use

LNI publishes its guidelines

LNI differs from DIN in some cases

What I miss:

other appearances in the wild of that style (besides "my" scientific-thesis-tempalte: https://github.com/latextemplates/scientific-thesis-template

minimal example using bibtex authorsalpha

a structured markdown file where the sources of the decisions are listed (and also a TL;DR summary is given) -- "keygenerators.md" in folder https://github.com/JabRef/jabref/tree/main/docs/code-howtos is a good place

Reason for the last point: We exchange information at multiple different places (which makes it scattered), but the core knowledge is not condensed. What if someone looks into that in one year - and if none of us both is available? --> Documentaiton enables asynchronous work.

Follow-up TODOs:

Collect knowledge in keygenerators.md. (New PR!)

Create .tex and .bib file for authorsalpha and the different cases (New PR)

Find usages of authorsalpha in the wild. (Add it to keygenerators.md. (New PR)

check institutions - example: author = {{Apache Foundation}}. It is OK if it fails, we just need to know and then think of solutions. For BibLaTeX, there is the feature label = {AF}. (add result to keygenerators.md - New PR). Add test case for that. Maybe commented out or marked with // TODO ...

I have handled the case of institutions now.

koppor · 2024-08-16T08:44:13Z

src/main/java/org/jabref/logic/citationkeypattern/BracketedPattern.java

+            if (lastName.startsWith("{") && lastName.endsWith("}")) {
+                alphaStyle.append(getOrganizationInitials(lastName));


Rewrite using org.jabref.logic.formatter.bibtexfields.RemoveEnclosingBracesFormatter

format the string using that formatter

if result is not equal -> you found an organization

Pass that string to getOrganizationInitials - the first two lines can be removed then.

koppor

Seems to be better than before 😅.

Follow-ups as discussed.

koppor · 2024-12-24T00:05:46Z

Checked documentation: Is the information available and up to date? If not, I created an issue at JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Where is the issue? There was no link in the PR description here - and at the issue tracker, I only found JabRef/user-documentation#453

subhramit · 2024-12-24T00:17:43Z

Where is the issue? There was no link in the PR description here - and at the issue tracker, I only found JabRef/user-documentation#453

The issue is mentioned in the PR description:

Investigation ref. #11577 and issue subhramit#17

I am/was not aware of any other existing issues around this. We started brainstorming when the requirement for adding alphanumeric style support in CSL came up (in the above pull/issue).

subhramit added 2 commits August 13, 2024 00:51

Fix authorsAlpha

8f54393

Merge branch 'main' into fix-authorsAlpha

e363e47

subhramit mentioned this pull request Aug 12, 2024

CSL4LibreOffice - C [GSoC '24] #11577

Merged

6 tasks

koppor mentioned this pull request Aug 12, 2024

Add support for alphanumeric styles subhramit/jabref#17

Closed

Add more test cases

cfc3c7f

koppor marked this pull request as draft August 12, 2024 20:00

subhramit added 2 commits August 13, 2024 20:38

Fix authorsAlpha - 2

e879e31

Fix tests

0131b9f

subhramit requested a review from koppor August 13, 2024 15:19

subhramit marked this pull request as ready for review August 13, 2024 15:27

subhramit added the [outdated] type: enhancement label Aug 13, 2024

Add tests for "van der" and other titles

4680f3c

subhramit added 2 commits August 14, 2024 04:52

Fix CitationKeyGeneratorTest

b889366

Fix BracketedPatternTest

603b9e3

Merge branch 'main' into fix-authorsAlpha

fc73b59

koppor requested changes Aug 15, 2024

View reviewed changes

subhramit added 3 commits August 16, 2024 08:40

Use Authors#getLastName

1d1bc0e

Merge remote-tracking branch 'origin/fix-authorsAlpha' into fix-autho…

f742712

…rsAlpha

Merge branch 'main' into fix-authorsAlpha

9926a1c

subhramit added 2 commits August 16, 2024 13:37

save

fd59be0

Handle organization names

274934a

koppor reviewed Aug 16, 2024

View reviewed changes

subhramit added 3 commits August 16, 2024 14:09

fix submodules part 1

45eb781

fix submodules part 1

a68d1c8

fix submodules part 2

2cf576d

koppor reviewed Aug 16, 2024

View reviewed changes

Use Braces Formatter

7992391

koppor approved these changes Aug 16, 2024

View reviewed changes

koppor enabled auto-merge August 16, 2024 09:14

koppor added this pull request to the merge queue Aug 16, 2024

Merged via the queue into JabRef:main with commit c3756e2 Aug 16, 2024
21 checks passed

koppor deleted the fix-authorsAlpha branch August 16, 2024 09:27

koppor mentioned this pull request Dec 24, 2024

Citation Key Generator does not work as described #12312

Open

2 tasks

		if (lastName.startsWith("{") && lastName.endsWith("}")) {
		alphaStyle.append(getOrganizationInitials(lastName));

Fix authorsAlpha #11614

Fix authorsAlpha #11614

Conversation

subhramit commented Aug 12, 2024 • edited Loading

Fix authorsAlpha

Mandatory checks

koppor commented Aug 12, 2024

koppor commented Aug 12, 2024

koppor commented Aug 12, 2024

subhramit commented Aug 12, 2024

koppor commented Aug 12, 2024

koppor commented Aug 12, 2024 • edited by subhramit Loading

subhramit commented Aug 12, 2024

koppor commented Aug 12, 2024

koppor commented Aug 12, 2024

subhramit commented Aug 12, 2024

subhramit commented Aug 12, 2024 • edited Loading

subhramit commented Aug 12, 2024 • edited Loading

koppor commented Aug 13, 2024

subhramit commented Aug 13, 2024

subhramit commented Aug 13, 2024 • edited Loading

subhramit commented Aug 13, 2024

koppor commented Aug 13, 2024

subhramit commented Aug 13, 2024 • edited Loading

koppor commented Aug 13, 2024

subhramit commented Aug 13, 2024

subhramit commented Aug 13, 2024 • edited Loading

koppor Aug 15, 2024

Choose a reason for hiding this comment

subhramit Aug 16, 2024 • edited Loading

Choose a reason for hiding this comment

koppor Aug 16, 2024

Choose a reason for hiding this comment

koppor Aug 15, 2024

Choose a reason for hiding this comment

subhramit Aug 16, 2024

Choose a reason for hiding this comment

koppor commented Aug 16, 2024

koppor commented Aug 16, 2024 • edited by subhramit Loading

koppor Aug 16, 2024

Choose a reason for hiding this comment

subhramit commented Aug 16, 2024

koppor Aug 16, 2024

Choose a reason for hiding this comment

subhramit Aug 16, 2024

Choose a reason for hiding this comment

koppor left a comment

Choose a reason for hiding this comment

koppor commented Dec 24, 2024

subhramit commented Dec 24, 2024

subhramit commented Aug 12, 2024 •

edited

Loading

koppor commented Aug 12, 2024 •

edited by subhramit

Loading

subhramit commented Aug 12, 2024 •

edited

Loading

subhramit commented Aug 12, 2024 •

edited

Loading

subhramit commented Aug 13, 2024 •

edited

Loading

subhramit commented Aug 13, 2024 •

edited

Loading

subhramit commented Aug 13, 2024 •

edited

Loading

subhramit Aug 16, 2024 •

edited

Loading

koppor commented Aug 16, 2024 •

edited by subhramit

Loading