[WIP] Fix issue no warning message

[juliusalberto]

Ref: #10121

This is a draft PR for the issue 10121. I made these changes based on the previous PR that was not merged - see #11484

I just want to have a sanity check on my approach to the issue. From what I read in the issue, the challenges are:

• org.jabref.gui.DialogService#notify should be called at the place
• Logger.warn(...) should be issued
• Challange: Pass DialogService down to the class where the issue is send...

I decided to tackle this issue by:

1. MoveFilesCleanup:

• Collects exceptions in a list during the cleanup process.
• Provides a getFileSystemExceptions() method to retrieve these exceptions.

2. CleanupWorker:

• Maintains its own list of exceptions.
• When running cleanup jobs, it checks if the job is a MoveFilesCleanup and if so, collects its exceptions.
• Provides a getFileSystemExceptions() method to retrieve all collected exceptions.

3. CleanupAction:

• After running the cleanup, it retrieves exceptions from the CleanupWorker.
• Displays these exceptions to the user using the DialogService.

Currently this is what is showing in my screen:

Question:

1. Am I doing this right or is this a bad code?
2. Do I have to throw JabrefExtension instead of FileSystemException?

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[github-actions]

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

[koppor]

The solution can be made more simpler: Use org.jabref.logic.util.NotificationService. Pass it down to the CleanupWorker.

[koppor]

Why not adding all IOException? They are logged below.

[juliusalberto]

I made this change based on the previous PR (#11484). I also think that it's better to add all of IOException.

Thanks for the input.

[koppor]

Think, we overlooked that thing in the PR (because of other comments 😅).

Side thing: Don't forget to run the OpenRewrite task and check checkstyle 😅

[github-actions]

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

[koppor]

@juliusalberto Does the close mean that you also want to be assigned at #10121?

[juliusalberto]

@koppor I think I'd create a new PR that is not a draft PR (I rewrote it from the main branch because reverting the commits is too much hassle). I will reference this PR in my new one

[koppor]

@koppor I think I'd create a new PR that is not a draft PR (I rewrote it from the main branch because reverting the commits is too much hassle). I will reference this PR in my new one

Without a new branch, you can do follow steps to start from scratch

1. git fetch upstream
2. git checkout fix-issue-no-warning-message to ensure you are on the branch
3. git reset --hard upstream/main to throw away your work
4. git push -f to remove all commits here on github
5. (continue working)

But nevermind. Maybe next time.

[juliusalberto]

Superseded by #11987