Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open specified folder in library properties #12223

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Open specified folder in library properties #12223

merged 6 commits into from
Nov 25, 2024

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Nov 24, 2024 •
edited
Loading

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/694

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 24, 2024
@Siedlerchr Siedlerchr requested a review from koppor November 24, 2024 11:54
@Siedlerchr @calixtus
Update src/main/java/org/jabref/gui/libraryproperties/general/General…
7cbe081 
…PropertiesViewModel.java

Co-authored-by: Carl Christian Snethlage <[email protected]>
Siedlerchr
Siedlerchr commented Nov 25, 2024
View reviewed changes
Copy link
Member Author

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getBrowseDirectory

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 23c2ad6 Nov 25, 2024
26 checks passed
@koppor koppor deleted the fixOpenDir branch November 25, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siedlerchr @koppor @calixtus