Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code enhancements for "GUI for consistency check" #12491

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

priyanshu16095
Copy link
Contributor

@priyanshu16095 priyanshu16095 commented Feb 11, 2025

Follow up to #12433

Refs. https://github.com/JabRef/jabref/pull/12433/files#r1948850390
This PR updates the code to use a List instead of a String and removes a redundant toString method in ConsistencyMessage.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@HoussemNasri
Copy link
Member

Please use a better PR title and keep the Follow up to' in PR description.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

@subhramit subhramit changed the title Follow up to #12433 Code enhancements for "GUI for consistency check" Feb 11, 2025
@subhramit
Copy link
Member

Hey @priyanshu16095, is this ready?

@priyanshu16095
Copy link
Contributor Author

Yes, its ready.

@subhramit subhramit marked this pull request as ready for review February 12, 2025 11:54
@subhramit subhramit enabled auto-merge February 12, 2025 11:55
@subhramit subhramit added this pull request to the merge queue Feb 12, 2025
Merged via the queue into JabRef:main with commit 5063bc3 Feb 12, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants