Disable incompatible properties for shared database #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +80,18 @@ public void setPanel(BasePanel panel) { | |||
| this.metaData = panel.getBibDatabaseContext().getMetaData(); | |||
| } | |||
|
|
|||
| public void updateEnableStatus() { | |||
| DatabaseLocation location = panel.getBibDatabaseContext().getLocation(); | |||
| boolean isNotShared = (location != DatabaseLocation.SHARED); | |||
There was a problem hiding this comment.
name it isShared. Reason: Negations should not be used in variable names.
obraliar
force-pushed
the
ImproveSharedDatabaseFeature
branch
from
30da6e7 to
55f0543
Compare
obraliar
force-pushed
the
ImproveSharedDatabaseFeature
branch
from
55f0543 to
ac70cff
Compare
koppor
changed the title
|
Noticing the new title of this PR, I am wondering if this PR affects the related help file ( http://help.jabref.org/en/DatabaseProperties ) |
|
LGTM 👍 |
boceckts
added
status: ready-for-review
boceckts
changed the title
|
LGTM! 👍 |
Siedlerchr
added a commit
that referenced
this pull request
Aug 25, 2016
* master: Disable incompatible properties for shared database. (#1826) Allow setting the etal-string empty. Implements #1841 (#1848) fix SplitPaneChangeListener (#1840) French localization: Jabref_fr: empty strings translated (#1847) Fixes #1687 "month" field ascending/descending sorting swapped (#1837) Fix localization entry. Update German translation (#1829) entry scrolling didn't work if the entry in question was just 1 row outside the table (bottom) (<; <= mistake) fix indent when pasting an entry search the entry from the back, b/c we want to select the duplicate, not the original fix issues and delete a duplicate method when inserting a duplicate the right entry will be selected
ayanai1
pushed a commit
to ayanai1/jabref
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1703.
Depends on: #1818 and https://github.com/JabRef/help.jabref.org/pull/57