[WIP] Adapt log4j configuration for junit tests #3511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
changed the title
Siedlerchr
changed the title
Siedlerchr
changed the title
Siedlerchr
added
status: ready-for-review
|
For travis this is ok, but with this configuration no errors and warnings are reported during debug sessions of tests, right? |
LinusDietz
approved these changes
Dec 24, 2017
|
@tobiasdiez This only applies if you run the tests through gradle. If you manually debug the test in the IDEA, it should be normal behaviour |
|
I just tried it and sadly it does not work in IntelliJ. For example, the method |
|
So what about this PR? It is marked as ready-to-review, but it seems it is not functional? |
5 tasks
tobiasdiez
removed
the
status: ready-for-review
tobiasdiez
changed the title
|
Can we get some progress here? The travis log is really annoying at the moment. I'll add this to jabcon in the hope that it gets done then. |
|
I think I have an idea: I commit my changes and add the files to .gitignore So it won't overwrite @tobiasdiez changes on merge/pull right? |
stefan-kolb
added a commit
that referenced
this pull request
Feb 6, 2018
Siedlerchr
added a commit
that referenced
this pull request
Feb 6, 2018
* 'master' of github.com:JabRef/jabref: Allow spaces in DOIs Remove irrelevant log messages during XMP reading Adapt log4j configuration for cleaner junit tests #3511 Eclipse Django style #3655 Better code style for chained methods Update build.gradle Update build.gradle cleanup and refactoring in DuplicateCheck class code review fixes - consider pages of the same book separately in duplications detection process; add more tests differentiate inbooks with the same author and title, but different chapter Remove deprecated static BibtexParser.parse method Use stream in matcher (#3696) Add some BibtexNameFomatter comments Add exception for Jacoco Set jacoco toolVersion earlier set jacoco version globally
Siedlerchr
added a commit
that referenced
this pull request
Feb 7, 2018
* upstream/master: (47 commits) Fix Google Scholar fetcher Use english for all LCID mappings #1851 remove import preferences test mock import and convert to junit5 fix #3693 (#3702) Fix space leads to jump in entry editor (#3699) Fix #3669 Extract creation of the contents of FileAnnotationTabController Fix changelog Fix NPE Remove unnecessary file use processbuilder for calling external apps Fix color highlight of odd linked files Fixes #2964 Fix koppor issues #3 Allow spaces in DOIs Remove irrelevant log messages during XMP reading Adapt log4j configuration for cleaner junit tests #3511 Eclipse Django style #3655 Better code style for chained methods Update build.gradle ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3510
After searching and reading around I now set the log level to off.
Failures are still reported, but the travis output is no longer cluttered
gradle localizationUpdate?