Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitter badge #3630

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Add gitter badge #3630

merged 1 commit into from
Jan 12, 2018

Conversation

koppor
Copy link
Member

@koppor koppor commented Jan 12, 2018

This addresses #3586

In the DevCall, we decided, that we will try to use Gitter and see how it goes.

The main arguments were:

We will shutdown gitter in case there won't be much support from @JabRef/developers there (because lack of time). Nevertheless, we give it a chance. 😇

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 12, 2018
@lenhard
Copy link
Member

lenhard commented Jan 12, 2018

Since testing gitter has been tentatively decided at the devcall, I'll merge this right away.

@lenhard lenhard merged commit 3bafdd8 into master Jan 12, 2018
@lenhard lenhard deleted the add-gitter branch January 12, 2018 15:56
@tobiasdiez
Copy link
Member

The gitter chat is meant as a platform to discuss developer's question and not to give user support, right? In this case, I would suggest to follow the rails example and create a contributing section in the readme with the two badges "code helpers" and "gitter" to make the context clear. In this new section, we could also add links to the contributing FAQ and the related wiki pages to make contributing even easier.

@lenhard
Copy link
Member

lenhard commented Jan 12, 2018

Yes, you are right: gitter is for developer's questions. Maybe I was to quick with merging, apologies!

Siedlerchr added a commit that referenced this pull request Jan 12, 2018
…into office007translator

* 'office007translator' of https://github.com/JabRef/jabref:
  Add Gitter badge and hint (#3630)
  Update CHANGELOG.md
  Add UI elements for validation in the preferences dialog
  Change style
  Reactivate validation in entry editor
Siedlerchr added a commit that referenced this pull request Jan 14, 2018
* upstream/master: (71 commits)
  New translations JabRef_en.properties (French)
  Add Gitter badge and hint (#3630)
  New translations JabRef_en.properties (Vietnamese)
  New translations JabRef_en.properties (Chinese Simplified)
  New translations JabRef_en.properties (Dutch)
  New translations JabRef_en.properties (French)
  New translations JabRef_en.properties (German)
  New translations JabRef_en.properties (Greek)
  New translations JabRef_en.properties (Indonesian)
  New translations JabRef_en.properties (Italian)
  New translations JabRef_en.properties (Japanese)
  New translations JabRef_en.properties (Norwegian)
  New translations JabRef_en.properties (Persian)
  New translations JabRef_en.properties (Portuguese, Brazilian)
  New translations JabRef_en.properties (Russian)
  New translations JabRef_en.properties (Spanish)
  New translations JabRef_en.properties (Swedish)
  New translations JabRef_en.properties (Turkish)
  New translations JabRef_en.properties (Danish)
  Update CHANGELOG.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants