Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial revert of #3715 since double click on group should expand/collapse it #3834

Merged
merged 1 commit into from
Mar 12, 2018
+1 −14
Merged

Partial revert of #3715 since double click on group should expand/collapse it #3834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ For more details refer to the [field mapping help page](http://help.jabref.org/e
- We improved file saving so that hard links are now preserved when a save is performed [#2633](https://github.com/JabRef/jabref/issues/2633)
- We changed the default dialog option when removing a [file link](http://help.jabref.org/en/FileLinks#adding-external-links-to-an-entry) from an entry.
The new default removes the linked file from the entry instead of deleting the file from disk. [#3679](https://github.com/JabRef/jabref/issues/3679)
- The group editing window can now also be called by double-clicking the group to be edited. [koppor#277](https://github.com/koppor/jabref/issues/277)
- The magnifier icon at the search shows the [search mode](https://help.jabref.org/en/Search#search-modes) again. [#3535](https://github.com/JabRef/jabref/issues/3535)
- We added a new cleanup operation that replaces ligatures with their expanded form. [#3613](https://github.com/JabRef/jabref/issues/3613)
- We added the function to parse German month names. [#3536](https://github.com/JabRef/jabref/pull/3536)
Expand Down
14 changes: 1 addition & 13 deletions src/main/java/org/jabref/gui/groups/GroupTreeController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import javafx.scene.input.ClipboardContent;
import javafx.scene.input.DragEvent;
import javafx.scene.input.Dragboard;
import javafx.scene.input.MouseButton;
import javafx.scene.input.TransferMode;
import javafx.scene.layout.StackPane;
import javafx.scene.text.Text;
Expand Down Expand Up @@ -173,18 +172,7 @@ public void initialize() {
// Simply setting to null is not enough since it would be replaced by the default node on every change
row.setDisclosureNode(null);
row.disclosureNodeProperty().addListener((observable, oldValue, newValue) -> row.setDisclosureNode(null));

// Opens the group's edit window when the group gets double clicked
row.setOnMouseClicked((mouseClickedEvent) -> {
if (mouseClickedEvent.getButton().equals(MouseButton.PRIMARY)
&& (mouseClickedEvent.getClickCount() == 2)) {
GroupNodeViewModel groupToEdit = row.itemProperty().getValue();
if (groupToEdit != null) {
viewModel.editGroup(groupToEdit);
}
}
});


// Add context menu (only for non-null items)
row.contextMenuProperty().bind(
EasyBind.monadic(row.itemProperty())
Expand Down