Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU leak #4058

Merged
merged 2 commits into from
Jun 1, 2018
Merged

CPU leak #4058

merged 2 commits into from
Jun 1, 2018

Conversation

stefan-kolb
Copy link
Member

See #3943

  • Fix Java to later version
  • Pretty restrictive for the user unfortunately!

@stefan-kolb stefan-kolb added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers status: devcall labels May 25, 2018
@stefan-kolb
Copy link
Member Author

@JabRef/developers I worked a little bit with Jabref 4.2 and the new JDK and I feel like also the problems with duplicated entries in the search box and freezes are less frequent now.
Maybe the constant load provokes these issues even more.
Therefore, I vote to release a new JR version where we force the users to upgrade to the newest Java JRE/JDK!

Also refs #3989.
Fixes #3943.

@Siedlerchr
Copy link
Member

Let me finish #4015 today and we can go for a release.

@stefan-kolb stefan-kolb added this to the v4.3 milestone May 30, 2018
@stefan-kolb
Copy link
Member Author

As this really improves the situation (at least for me), I think we should definitly include this in our release.

@stefan-kolb stefan-kolb merged commit cdb2de6 into master Jun 1, 2018
@stefan-kolb stefan-kolb deleted the cpu-leak branch June 1, 2018 08:59
Siedlerchr added a commit that referenced this pull request Jun 1, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixCustomExportFi…
4c07cd0 
…leType

* upstream/master:
  Show development information
  Release v4.3
  Remove invalid test and fix another
  CPU leak #3943 (#4058)

# Conflicts:
#	CHANGELOG.md
@koppor koppor mentioned this pull request Jun 5, 2018
Merged
6 tasks
@koppor
Copy link
Member

koppor commented Jun 5, 2018

@stefan-kolb Which tool did you use for the CPU monitoring?

I tried java version "1.8.0_171" and it doesn't seem to cause high CPU load.

Focused entry editor:

grafik

Unfocused entry editor:

grafik

@stefan-kolb
Copy link
Member Author

stefan-kolb commented Jun 5, 2018 •
edited
Loading

I used the visualvm. It is actually not caused by the entry editor but by switching between programs.
Let me check v1.8.0_171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@stefan-kolb @Siedlerchr @koppor