Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double-click onto file in file list to just open the file #7523

Merged
merged 2 commits into from
Mar 13, 2021
Merged

Fix double-click onto file in file list to just open the file #7523

merged 2 commits into from
Mar 13, 2021

Conversation

mohit038-zz
Copy link
Contributor

Fixes #7465

Now double click onto the file just open the file and edit prompt can be accessed through a new right-click > Edit option.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@mohit038-zz mohit038-zz marked this pull request as ready for review March 13, 2021 10:46
Siedlerchr
Siedlerchr approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm!

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 13, 2021
tobiasdiez
tobiasdiez approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tobiasdiez tobiasdiez merged commit a0c7a86 into JabRef:master Mar 13, 2021
Siedlerchr added a commit that referenced this pull request Mar 14, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into master
85389e4 
* upstream/master:
  [create-pull-request] automated change (#7530)
  Fix:Double-click to open a file (#7523)
  Extends dark theme to group custom-color-picker (#7520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double-click onto PDF in file list should just open the file
3 participants
@mohit038-zz @Siedlerchr @tobiasdiez