Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gradle 7.4.2 and jdk18 #8629

Merged
merged 7 commits into from
May 9, 2022
Merged

Update to gradle 7.4.2 and jdk18 #8629

merged 7 commits into from
May 9, 2022

Conversation

calixtus
Copy link
Member

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers dev: build-system gradle-wrapper Pull requests that update Gradle wrapper labels Mar 31, 2022
@koppor
Copy link
Member

koppor commented Mar 31, 2022

News of Java 18: https://www.infoworld.com/article/3630510/jdk-18-the-new-features-in-java-18.html - especially UTF-8 as default - yeah 🎉

@koppor
Copy link
Member

koppor commented Mar 31, 2022

IntelliJ doesn't seem to support Java 18 (yet): https://www.jetbrains.com/help/idea/supported-java-versions.html#2021 - maybe, we should wait until there is an IntelliJ update?

@calixtus
Copy link
Member Author

calixtus commented Apr 1, 2022

I agree. There is no hurry.

@Siedlerchr Siedlerchr added this to the v6.0 milestone Apr 3, 2022
@koppor
Copy link
Member

koppor commented Apr 25, 2022

https://whichjdk.com/ --> UTF-8 as default

grafik

Nevertheless, as soon as Eclipse supports JDK18, we should update

@koppor
Copy link
Member

koppor commented May 9, 2022

Fetcher tests failing is mostly IEEE:

java.io.IOException: Server returned HTTP response code: 503 for URL: https://ieeexplore.ieee.org/document/7421926/

@Siedlerchr Siedlerchr merged commit 177d5ec into main May 9, 2022
@Siedlerchr Siedlerchr deleted the jdk18 branch May 9, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: build-system gradle-wrapper Pull requests that update Gradle wrapper status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants