Improve error handling

[JacobCallahan]

This change introduces a ton more situations where errors are passed up instead of resulting in an unrecoverable panic.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

src/connection.rs:327

• The new error handling path introduced here is not covered by tests. Ensure that the error handling for scp_recv is tested.

let (mut remote_file, stat) = self.session.scp_recv(Path::new(&remote_path)).map_err(|e| PyErr::new::<PyIOError, _>(format!("Failed scp_recv: {}", e)))?;

src/connection.rs:334

• The new error handling path introduced here is not covered by tests. Ensure that the error handling for File::create is tested.

let mut local_file = std::fs::File::create(&local_path).map_err(|e| PyErr::new::<PyIOError, _>(format!("File create error: {}", e)))?;

src/connection.rs:338

• The new error handling path introduced here is not covered by tests. Ensure that the error handling for remote_file.read is tested.

let len = remote_file.read(&mut buffer).map_err(|e| PyErr::new::<PyIOError, _>(format!("Read error: {}", e)))?;

src/connection.rs:344

• The new error handling path introduced here is not covered by tests. Ensure that the error handling for local_file.write_all is tested.

local_file.write_all(&buffer[..len]).map_err(|e| PyErr::new::<PyIOError, _>(format!("Write error: {}", e)))?;

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/connection.rs:753

• Using unwrap_or(0) here might mask an error. Consider handling the error explicitly.

self.last_pos = metadata.size.unwrap_or(0);

src/connection.rs:767

• [nitpick] The error message 'Opening remote file failed' is not very informative. Consider providing more context about the error.

.expect("Opening remote file failed"),