Update Local #1
Merged
Update Local #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* forEach on methods converted to ES1 for loop - leaving comments for PR review confirmation * forEach converted to forloop -- function ensures middleware is a function * let & const to var for potential small perf -- tests passing in both commits * Removed comments -- git can be used to diff the logic * forEach converted to for loop -- seems to build the middleware for server use * forEach converted to for loop -- param for loop needed a function closure to not hang up the tests * setPrefix forEach converted -- all 92 tests passing - Renamed the previous function to setFUNCTION * support array of paths -- 92 tests pass * converted forEach loop that iterates over cloneRouter stack * converted route matching and method assign nested loop * converted loop that supports array of paths and registers routes * converted add parameter middleware loop -- all 92 tests passing * Last forEach converted -- also removed a unused param from a function - All 92 tests passing - Some code cleanup - Minor formatting mainly to refactored sections - No benchmarks currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.