Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not automatically generate <label>. only use ngMessages. #111

Closed
JSlain opened this issue Feb 2, 2017 · 3 comments
Closed

Do not automatically generate <label>. only use ngMessages. #111

JSlain opened this issue Feb 2, 2017 · 3 comments

Comments

@JSlain
Copy link
Contributor

JSlain commented Feb 2, 2017

I see in the Feature list:

Supports custom validation message templates and placement using Angular's native ngMessages directive.

We want complete control over the way we display the error messages, so i thought about using this feature. The messages actually appears as we wishes in our <div ng-messages ... > , but angular-validator still adds it's own generated <label> at some location we definitely don't want.

Is there a way to disable the auto-generated <label>?

JSlain added a commit to JSlain/angular-validator that referenced this issue Feb 2, 2017
JSlain added a commit to JSlain/angular-validator that referenced this issue Feb 3, 2017
…with the angular version. Just use manual templating for the demo app
@mrmashal
Copy link

mrmashal commented Feb 8, 2017

Would you mind including a sample using ngMessages in the docs?

Jakobovski added a commit that referenced this issue Feb 8, 2017
Issue #111: Prevent generation of <label> with attribute "angular-val…
@Jakobovski
Copy link
Owner

merged thanks!

@JSlain
Copy link
Contributor Author

JSlain commented Feb 8, 2017

@mrmashal I tried but i had conflict with versions of angular. Since i don't know bower very much, it was simpler for me to just remove it and make an example using native angular directives.

I'll take some time to figure out how it works and put back my angular-messages example, in another pull request. Angular-messages is not exactly related to my modification, but an example using it could be very useful. Indeed.

JSlain added a commit to JSlain/angular-validator that referenced this issue Feb 19, 2017
Jakobovski added a commit that referenced this issue Feb 28, 2017
Issue #111: Adjusted the demo to use angular-messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants