Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure .copy isnt necessary for different parts of data #16

Open
Jammy2211 opened this issue Mar 13, 2019 · 0 comments
Open

Make sure .copy isnt necessary for different parts of data #16

Jammy2211 opened this issue Mar 13, 2019 · 0 comments

Comments

@Jammy2211
Copy link
Owner

The noise-scaling maps were not being extracted correctly, because the self.chi_squared_map was being altered when we extract them from a ci_fit:

    @property
    def noise_scaling_map_of_ci_regions(self):
        return self.ci_data_fit.chinj.ci_regions_from_array(array=self.chi_squared_map)

I fixed this by copying the array.


    @property
    def noise_scaling_map_of_ci_regions(self):
        return self.ci_data_fit.chinj.ci_regions_from_array(array=self.chi_squared_map.copy())

We need to make sure this sort of thing isn't happening anywhere else we extract arrays from ci_frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant