Feature/jax merge #215
Open
Feature/jax merge #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multipole Fix
feature/mutlipole_2
Feature/disable noise
feature/delaunay_visual
errors -> reconstruction_noise_map
feature/operate deflections api
…lections_api Revert "feature/operate deflections api"
Feature/over sampling refactor
rhayes777
approved these changes
Jan 24, 2025
Comment on lines
+50
to
+51
| if fit.children is not None: | ||
| if len(fit.children) > 0: |
There was a problem hiding this comment.
None and empty array are both falsey
if fit.children:
...
Comment on lines
+50
to
+51
| print("clicked on the pixel:", y_pixels, x_pixels) | ||
| print("Max flux pixel:", y_pixels_max, x_pixels_max) |
There was a problem hiding this comment.
Replace print statements with logging?
| # | ||
| # fit = ag.FitEllipse(dataset=imaging_lh, ellipse=ellipse_0) | ||
| # | ||
| # assert fit.mask_interp == pytest.approx([False, False, False, False, False], 1.0e-4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update feature/jax_wrapper with changes from main