Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(path): add entry to PATH if non existant #69

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat(path): add entry to PATH if non existant #69

merged 1 commit into from
Nov 23, 2023

Conversation

JanDeDobbeleer
Copy link
Owner

resolves #62

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

@trajano
Copy link

trajano commented Nov 8, 2023

Yup this does the first request which is to check for existence, but I think we can make it more shell/platform neutral by creating the directory if it can be configured to do so.

@JanDeDobbeleer
Copy link
Owner Author

@trajano imho, creating a directory is no use-case here. That's beyond the scope of aliae. You can add that to the script block. I'm going to be strict in what we can or can't do, because otherwise this will become a dragon of a tool.

@JanDeDobbeleer JanDeDobbeleer merged commit 573f64f into main Nov 23, 2023
6 checks passed
@JanDeDobbeleer JanDeDobbeleer deleted the path branch November 23, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path should have an option to check for existence before adding.
2 participants