Fixed Java brush matrix #2646
Fixed Java brush matrix #2646
Conversation
Nestorboy
commented
Jan 17, 2025
Nestorboy
commented
- Replaced the temporary brush outline offset fix with a proper solution that makes the brush account for every kind of scene transformation.
- Fixed issue where z-offset was not being applied anymore when working with java models.
This reverts commit 3039c28.
Since we're applying the brush matrix directly, we need to factor in the parent matrices too, since the brush is parented to the scene. By using the parent matrix instead, we make it account for all translations, rotations and scaling.
|
I noticed that the z-offset wasn't being applied anymore for the Java models. I did fix depth sorting for such cases to make sure that the brush would usually draw in front, but I haven't done any stress testing to make sure that it's always the case, since there might be floating point precision issues in more extreme cases that can cause the GPU-side depth offset for the brush to not be enough and cause z-fighting again. Since this might need more testing I would probably avoid adding this to 4.12.x. What do you think @JannisX11? |
|
Yup, I agree. I haven't noticed any z fighting issues so far, and even if it happens in extreme cases I'm not worried about it since it's just the brush outline. Maybe in the next update cycle. Thanks for the fix! I didn't realize makeTranslation wasn't additive. |
