Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-auth-server): always save access_token to persistence regardless of cache configuration #10763

Closed
yuriyz opened this issue Jan 30, 2025 · 0 comments · Fixed by #10784
Closed

fix(jans-auth-server): always save access_token to persistence regardless of cache configuration #10763

yuriyz opened this issue Jan 30, 2025 · 0 comments · Fixed by #10784
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone
1.4.0

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Jan 30, 2025 •
edited
Loading

Describe the bug
We need to always save access_token to persistence regardless of cache configuration.

To Reproduce
Set AS to save tokens only in cache. And then call /end_session. It kills tokens if it's not in cache. But if AT goes to cache then AS has no way to identify such tokens.

Expected behavior
It should clear all tokens bound to this session.

This was discovered during GluuFederation/gluu4#86
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jan 30, 2025
yuriyz added a commit that referenced this issue Feb 3, 2025
@yuriyz
fix(jans-auth-server): always save access_token to persistence regard…
16ae9cb 
…less of cache configuration #10763

Signed-off-by: YuriyZ <[email protected]>
@yuriyz yuriyz mentioned this issue Feb 3, 2025
Merged
1 task
yuriyz added a commit that referenced this issue Feb 3, 2025
@yuriyz
fix(jans-auth-server): always save access_token to persistence regard…
cf8ce67 
…less of cache configuration #10763 (#10784)

Signed-off-by: YuriyZ <[email protected]>
@yuriyz yuriyz assigned yuriyz and unassigned moabu Feb 3, 2025
@mo-auto mo-auto mentioned this issue Feb 10, 2025
Merged
@moabu moabu added this to the 1.4.0 milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.4.0
3 participants
@yuriyz @moabu @mo-auto