Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-cedarling): add krakend plugin #10713

Merged
merged 16 commits into from
Jan 23, 2025
Merged

feat(jans-cedarling): add krakend plugin #10713

merged 16 commits into from
Jan 23, 2025

Conversation

SafinWasi
Copy link
Contributor

Prepare

Description

Target issue

closes #10704

Implementation Details

Test and Document the changes

N/A

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@SafinWasi SafinWasi requested a review from moabu as a code owner January 21, 2025 16:15
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request labels Jan 21, 2025
nynymike
nynymike reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@nynymike nynymike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we test the plugin?

moabu
moabu previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@moabu moabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we push the

nynymike
nynymike previously approved these changes Jan 22, 2025
View reviewed changes
@moabu moabu merged commit 78457b6 into main Jan 23, 2025
7 checks passed
@moabu moabu deleted the feat-sidecar-krakend-plugin branch January 23, 2025 10:24
@mo-auto mo-auto mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nynymike nynymike nynymike approved these changes

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-cedarling): add krakend plugin
4 participants
@SafinWasi @nynymike @moabu @mo-auto