feat(jans-cedarling): create uniffi binding for cedarling with sample ios app using it #10816

duttarnab · 2025-02-09T17:03:29Z

closes #9432

Prepare

Read PR guidelines
Read license information

Description

Target issue

closes #issue-number-here

Implementation Details

Test and Document the changes

Static code analysis has been run locally and issues have been fixed
Relevant unit and integration tests have been added/updated
Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: duttarnab <[email protected]>

jans-cedarling/bindings/cedarling_native_apps/README.md

Signed-off-by: duttarnab <[email protected]>

jans-cedarling/bindings/cedarling_native_apps/iOSApp/iOSApp/context.json

nynymike

I see the Readme, but is there an impact on the docs?

Docs Added

nynymike · 2025-02-10T17:30:21Z

I'd like @NazarYavornytskyy to review this PR, as he's the most experienced iOS developer on our team.

olehbozhok · 2025-02-10T18:04:10Z

Actually I don't really understand name jcedarling_native_apps because it is not native implementation it is uniffi implementation.

olehbozhok · 2025-02-10T18:05:27Z

Also, I see a lot of print in code. And I can't believe it is good approach for logging.

olehbozhok · 2025-02-10T18:06:10Z

It is supposed to be Swift application or only lib to import to real application?

olehbozhok · 2025-02-10T18:17:00Z

jans-cedarling/bindings/cedarling_native_apps/src/lib.rs

+        request_id: &str,
+        tag: &str,
+    ) -> Result<Vec<String>, LogError> {
+        let mut result = Vec::new();


We can allocate result with defined capacity. With length from result self.inner.get_logs_by_request_id_and_tag(request_id, tag)

olehbozhok · 2025-02-10T18:17:16Z

jans-cedarling/bindings/cedarling_native_apps/src/lib.rs

+    /// Return log entries that match the given request_id.
+    #[uniffi::method]
+    pub fn get_logs_by_request_id(&self, request_id: &str) -> Result<Vec<String>, LogError> {
+        let mut result = Vec::new();


We can allocate result with defined capacity

olehbozhok · 2025-02-10T18:17:25Z

jans-cedarling/bindings/cedarling_native_apps/src/lib.rs

+    /// Tag can be `log_kind`, `log_level`.
+    #[uniffi::method]
+    pub fn get_logs_by_tag(&self, tag: &str) -> Result<Vec<String>, LogError> {
+        let mut result = Vec::new();


We can allocate result with defined capacity

olehbozhok · 2025-02-10T18:17:29Z

jans-cedarling/bindings/cedarling_native_apps/src/lib.rs

+    //Get all log ids
+    #[uniffi::method]
+    pub fn get_log_ids(&self) -> Vec<String> {
+        let mut result = Vec::new();


We can allocate result with defined capacity

olehbozhok · 2025-02-10T18:17:39Z

jans-cedarling/bindings/cedarling_native_apps/src/lib.rs

+    // Retrieves logs and serializes them as JSON strings
+    #[uniffi::method]
+    pub fn pop_logs(&self) -> Result<Vec<String>, LogError> {
+        let mut result = Vec::new();


We can allocate result with defined capacity

olehbozhok · 2025-02-10T18:23:53Z

jans-cedarling/bindings/cedarling_native_apps/Cargo.toml

+crate_type = ["cdylib", "staticlib"]
+name = "mobile"
+
+[dependencies]


To avoid error in compile wasm tests you can use

# dependency for NOT wasm target [target.'cfg(not(target_arch = "wasm32"))'.dependencies]

instead of [dependencies] like here

and don't forget to add this in lib.rs

Signed-off-by: duttarnab <[email protected]>

olehbozhok · 2025-02-11T15:06:21Z

jans-cedarling/bindings/cedarling_native_apps/src/lib.rs

+
+// Struct to hold authorization result, compatible with iOS serialization
+#[derive(Debug, serde::Serialize, uniffi::Record)]
+pub struct AuthorizeResult {


I don't see how user can get request_id
https://github.com/JanssenProject/jans/blob/main/jans-cedarling/cedarling/src/authz/authorize_result.rs#L35C9-L35C19

Signed-off-by: duttarnab <[email protected]>

olehbozhok · 2025-02-17T23:35:32Z

jans-cedarling/bindings/cedarling_uniffi/src/request_wrapper.rs

+    ) -> Result<Self, RequestError> {
+        // Validate tokens: ensure all values are non-empty after trimming
+        let mut validated_tokens = HashMap::new();
+        for (key, value) in tokens.iter() {


Is it possible to use tokens.into_iter(), and avoid cloning of key?

olehbozhok

Looks OK to me.

olehbozhok · 2025-02-18T00:09:33Z

You can use next code snippet to avoid cargo error

bindings/cedarling_uniffi/src/bin/uniffi-bindgen.rs

#[cfg(not(target_arch = "wasm32"))]
fn main() {
    uniffi::uniffi_bindgen_main()
}

// just to avoid clippy error about missing `main` function
#[cfg(target_arch = "wasm32")]
fn main() {
}

Signed-off-by: duttarnab <[email protected]>

feat: initial commit for ios binding

b53e0fd

Signed-off-by: duttarnab <[email protected]>

mo-auto added comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request labels Feb 9, 2025

duttarnab added 3 commits February 9, 2025 22:41

feat: commiting remaining files

5a37e67

Signed-off-by: duttarnab <[email protected]>

feat: pushing uniffi-bindgen.rs file

55aa63d

Signed-off-by: duttarnab <[email protected]>

feat: adding Gluu's copyright and software license

6265650

Signed-off-by: duttarnab <[email protected]>

duttarnab requested review from olehbozhok, rmarinn and nynymike February 9, 2025 17:33

rmarinn reviewed Feb 10, 2025

View reviewed changes

jans-cedarling/bindings/cedarling_native_apps/README.md Outdated Show resolved Hide resolved

duttarnab added 2 commits February 10, 2025 12:50

feat: adding android section in README

38e73ab

Signed-off-by: duttarnab <[email protected]>

feat: restoring python binding

c7a1ae9

Signed-off-by: duttarnab <[email protected]>

rmarinn reviewed Feb 10, 2025

View reviewed changes

jans-cedarling/bindings/cedarling_native_apps/iOSApp/iOSApp/context.json Outdated Show resolved Hide resolved

rmarinn previously approved these changes Feb 10, 2025

View reviewed changes

nynymike reviewed Feb 10, 2025

View reviewed changes

nynymike requested a review from NazarYavornytskyy February 10, 2025 17:29

olehbozhok requested changes Feb 10, 2025

View reviewed changes

olehbozhok changed the title ~~feat: initial commit for ios binding~~ feat(jans-cedarling): initial commit for ios binding Feb 10, 2025

olehbozhok assigned duttarnab Feb 10, 2025

NazarYavornytskyy previously approved these changes Feb 11, 2025

View reviewed changes

feat: update README and add fix to prevent WASM test failure

c981cd5

Signed-off-by: duttarnab <[email protected]>

duttarnab dismissed stale reviews from NazarYavornytskyy and rmarinn via c981cd5 February 11, 2025 11:29

feat: correct typo in README

63121bb

Signed-off-by: duttarnab <[email protected]>

olehbozhok requested changes Feb 11, 2025

View reviewed changes

feat: resolving review comments

00ad00d

Signed-off-by: duttarnab <[email protected]>

duttarnab added 3 commits February 17, 2025 01:13

feat: remove unused imports

42b6747

Signed-off-by: duttarnab <[email protected]>

feat: add demo video in docs

c52bb5c

Signed-off-by: duttarnab <[email protected]>

feat: correct typo

6572058

Signed-off-by: duttarnab <[email protected]>

nynymike previously approved these changes Feb 16, 2025

View reviewed changes

fix: export uniffi::uniffi_bindgen_main

b61ed3f

Signed-off-by: duttarnab <[email protected]>

duttarnab dismissed nynymike’s stale review via b61ed3f February 17, 2025 04:32

duttarnab added 4 commits February 17, 2025 10:28

fix: export uniffi::uniffi_bindgen_main

b9b1556

Signed-off-by: duttarnab <[email protected]>

fix: fixing wasm build error

deae330

Signed-off-by: duttarnab <[email protected]>

fix: fixing wasm build error

af9dfe3

Signed-off-by: duttarnab <[email protected]>

feat: adding title to logs

9966c04

Signed-off-by: duttarnab <[email protected]>

nynymike previously approved these changes Feb 17, 2025

View reviewed changes

olehbozhok reviewed Feb 17, 2025

View reviewed changes

olehbozhok previously approved these changes Feb 17, 2025

View reviewed changes

feat: resolving clippy error about missing function

989d8ea

Signed-off-by: duttarnab <[email protected]>

duttarnab dismissed stale reviews from olehbozhok and nynymike via 989d8ea February 18, 2025 08:29

duttarnab added 4 commits February 18, 2025 14:19

feat: resolving clippy error about missing function

65cf3b0

Signed-off-by: duttarnab <[email protected]>

feat: resolving clippy error about missing function

0a6d218

Signed-off-by: duttarnab <[email protected]>

Merge branch 'main' into jans-cedarling-issue-9432_2

7ea6a3b

feat: resolving clippy error about empty line above main function

66d11b8

Signed-off-by: duttarnab <[email protected]>

duttarnab requested review from nynymike and olehbozhok February 18, 2025 09:31

duttarnab changed the title ~~feat(jans-cedarling): initial commit for ios binding~~ feat(jans-cedarling): create unifi bining for cedarling with sample ios app using it Feb 18, 2025

duttarnab changed the title ~~feat(jans-cedarling): create unifi bining for cedarling with sample ios app using it~~ feat(jans-cedarling): create uniffi bining for cedarling with sample ios app using it Feb 18, 2025

duttarnab changed the title ~~feat(jans-cedarling): create uniffi bining for cedarling with sample ios app using it~~ feat(jans-cedarling): create uniffi binding for cedarling with sample ios app using it Feb 18, 2025

olehbozhok approved these changes Feb 18, 2025

View reviewed changes

nynymike approved these changes Feb 18, 2025

View reviewed changes

duttarnab merged commit 026ed0b into main Feb 18, 2025
72 of 84 checks passed

duttarnab deleted the jans-cedarling-issue-9432_2 branch February 18, 2025 16:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(jans-cedarling): create uniffi binding for cedarling with sample ios app using it #10816

feat(jans-cedarling): create uniffi binding for cedarling with sample ios app using it #10816

duttarnab commented Feb 9, 2025 •

edited

Loading

nynymike left a comment •

edited by duttarnab

Loading

nynymike commented Feb 10, 2025

olehbozhok commented Feb 10, 2025

olehbozhok commented Feb 10, 2025

olehbozhok commented Feb 10, 2025

olehbozhok Feb 10, 2025

duttarnab Feb 16, 2025

olehbozhok Feb 10, 2025

duttarnab Feb 16, 2025

olehbozhok Feb 10, 2025

duttarnab Feb 16, 2025

olehbozhok Feb 10, 2025

duttarnab Feb 16, 2025

olehbozhok Feb 10, 2025

duttarnab Feb 16, 2025

olehbozhok Feb 10, 2025 •

edited

Loading

duttarnab Feb 16, 2025

olehbozhok Feb 11, 2025

duttarnab Feb 16, 2025

olehbozhok Feb 17, 2025

duttarnab Feb 18, 2025

olehbozhok left a comment

olehbozhok commented Feb 18, 2025

feat(jans-cedarling): create uniffi binding for cedarling with sample ios app using it #10816

feat(jans-cedarling): create uniffi binding for cedarling with sample ios app using it #10816

Conversation

duttarnab commented Feb 9, 2025 • edited Loading

Prepare

Description

Target issue

Implementation Details

Test and Document the changes

nynymike left a comment • edited by duttarnab Loading

Choose a reason for hiding this comment

nynymike commented Feb 10, 2025

olehbozhok commented Feb 10, 2025

olehbozhok commented Feb 10, 2025

olehbozhok commented Feb 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olehbozhok Feb 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olehbozhok left a comment

Choose a reason for hiding this comment

olehbozhok commented Feb 18, 2025

duttarnab commented Feb 9, 2025 •

edited

Loading

nynymike left a comment •

edited by duttarnab

Loading

olehbozhok Feb 10, 2025 •

edited

Loading