New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSAssert on bar height in JBBarChartView, > 0 when it should be >= #22

Closed

simonbromberg opened this issue Mar 19, 2014 · 1 comment

simonbromberg commented Mar 19, 2014

In JBBarChartView.m you have the following line:

        NSAssert(height > 0, @"JBBarChartView // datasource function - (CGFloat)barChartView:(JBBarChartView *)barChartView heightForBarViewAtAtIndex:(NSUInteger)index must return a CGFloat >= 0");

The assert tests if height is greater than zero, the message says >= 0

If you pass a 0 for the height (perfectly valid height) the app crashes.

The text was updated successfully, but these errors were encountered:

terryworona pushed a commit that referenced this issue


          Fixed issue #22

d3a1ce1

Collaborator

terryworona commented Mar 19, 2014

Good catch! Sorry about that one. Fixed in commit: d3a1ce1

terryworona closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment