Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callbacks #483

Merged

Conversation

stefanocortinovis
Copy link
Contributor

Checklist

  • [ x ] I've formatted the new code by running hatch run dev:format before committing.
  • [ NA ] I've added tests for new code.
  • [ NA ] I've added docstrings for the new code.

Description

Migrate from jax.experimental.host_callback() to jax.debug.callback() (see here). Fixes #479.

Issue Number: #479

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into GPJax!

If you have not heard from us in a while, please feel free to ping @gpjax/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on Slack for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@daniel-dodd
Copy link
Member

Thanks @stefanocortinovis!

@thomaspinder
Copy link
Collaborator

Thanks for fixing this so swiftly @stefanocortinovis. Pending successful tests, could you please bump this line to 0.9.3?

@stefanocortinovis
Copy link
Contributor Author

Hi @daniel-dodd, @thomaspinder! I've opened a couple of other PRs. Happy to bump the version once you are happy with the changes!

@thomaspinder thomaspinder merged commit 823c931 into JaxGaussianProcesses:main Nov 1, 2024
11 checks passed
@stefanocortinovis stefanocortinovis deleted the fix_callback branch November 1, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: NotImplementedError when fitting Sparse GP
3 participants