add onKeyup handler #111
Closed
add onKeyup handler #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rickbergfalk if you'd be interested, I threw up react-codemirror2 which has key events. I'm hoping to maintain this moving forward so give it a look if you get a chance and feel free to open up an issue if you have any suggestions. |
|
Closing this PR. We've switched over to react-codemirror2. Thanks @scniro! react-codemirror2 is a really nice and comprehensive wrapper for codemirror 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds prop handler for keyup event. Went with
onKeyupsince event iskeyup, but I’d also be okay withonKeyUpif preferred.Primary goal for adding this is to be able to fire autocomplete on keyup event, as mentioned in #52 and #80.
Let me know if there’s anything I can do to assist getting this merged.
Thanks for the work on this library!