Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md and example to add changeObj parameter to onChange property #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YilinGao
Copy link

I read React-CodeMirror's source code and found that the onChange property actually has 2 return values, i.e, newCode and changeObj, instead of the only one newCode in the current document. With changeObj programmers can do more elaborate work (eg, emitting event of changed values instead of the whole trunk of new code). I regard it worthwhile to document this second parameter to give programmers more choices.

@YilinGao YilinGao changed the title Update README.md to add changeObj to onChange Update README.md and example to add changeObj parameter to onChange property Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant