Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export FilterOptionOption #5535

Closed
KevinKibler opened this issue Jan 11, 2023 · 4 comments · Fixed by #5993
Closed

Export FilterOptionOption #5535

KevinKibler opened this issue Jan 11, 2023 · 4 comments · Fixed by #5993
Labels
issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet

Comments

@KevinKibler
Copy link

KevinKibler commented Jan 11, 2023

Export the FilterOptionOption type so it doesn't need to be imported from dist/declarations/src

@KevinKibler KevinKibler added the issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet label Jan 11, 2023
@jhirshman
Copy link

was this ever resolved. I'm having problems upgrading to new versions of react-select

I'm currently importing as in 5.3.0

import { FilterOptionOption } from "react-select/dist/declarations/src/filters"

in 5.8.0

error TS2307: Cannot find module 'react-select/dist/declarations/src/filters' or its corresponding type declarations.

@ErikBrendel
Copy link

Same problem here. I have to stay on 5.6.1, otherwise the import import { FilterOptionOption } from 'react-select/dist/declarations/src/filters'; from react-select-async-paginate does not work with "moduleResolution": "Bundler" in my tsconfig.

@Methuselah96
Copy link
Collaborator

Can someone create a PR adding the export of FilterOptionOption from ./packages/react-select/src/filters.ts to ./packages/react-select/src/index.ts? If someone else creates the PR, I can review, merge, and release it.

@onihani
Copy link
Contributor

onihani commented Jan 17, 2025

Can someone create a PR adding the export of FilterOptionOption from ./packages/react-select/src/filters.ts to ./packages/react-select/src/index.ts? If someone else creates the PR, I can review, merge, and release it.

I have created a PR exposing the FilterOptionOption interface and linked to issue.
But the ci/circleci: end_to_end and ci/codesandbox checks are not passing

Could check and let me know to resolve this checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants