Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export FilterOptionOption #5993

Merged
merged 10 commits into from
Jan 24, 2025

Conversation

onihani
Copy link
Contributor

@onihani onihani commented Jan 17, 2025

Fixes #5535

exported FilterOptionOption from ./packages/react-select/src/filters.ts to ./packages/react-select/src/index.ts

Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: 593ccad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@onihani onihani marked this pull request as draft January 17, 2025 15:08
@onihani onihani marked this pull request as ready for review January 17, 2025 15:09
@onihani onihani marked this pull request as draft January 17, 2025 15:09
Copy link

codesandbox-ci bot commented Jan 17, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Methuselah96
Copy link
Collaborator

You may need to change the Docker build image to use a newer version of Node? Try changing the Docker image in react-select/.circleci/config.yml from cypress/browsers:node16.17.1-chrome106-ff105-edge to cypress/browsers:latest.

@Methuselah96
Copy link
Collaborator

@onihani Sorry the build was not working, I pushed a commit to get it working again. I think all that's left is to add a changeset and mark the PR as ready for review. Let me know if you need anything else.

@onihani
Copy link
Contributor Author

onihani commented Jan 17, 2025

@onihani Sorry the build was not working, I pushed a commit to get it working again. I think all that's left is to add a changeset and mark the PR as ready for review. Let me know if you need anything else.

Thanks a lot for resolving the build issue
I would add the changeset and push asap

@onihani onihani marked this pull request as ready for review January 24, 2025 11:41
@onihani
Copy link
Contributor Author

onihani commented Jan 24, 2025

@Methuselah96 I have added the changeset and marked the PR as ready for review

@Methuselah96 Methuselah96 changed the title exported FilterOptionOption Export FilterOptionOption Jan 24, 2025
Copy link
Collaborator

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit 6d28ed7 into JedWatson:master Jan 24, 2025
6 checks passed
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export FilterOptionOption
2 participants