presets + cmake.buildToolArgs: make sure -- is added in all cases

Fixes microsoft#3754. This issue was introduced in microsoft#3537 (cmake.buildToolsArgs was ignored for presets before).
JeremieA · May 13, 2024 · 58816fa · 58816fa
1 parent e0f9f61
commit 58816fa
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/preset.ts b/src/preset.ts
@@ -2047,8 +2047,11 @@ export function buildArgs(preset: BuildPreset, tempOverrideArgs?: string[], temp
     }
 
     tempOverrideArgs && result.push(...tempOverrideArgs);
-    preset.nativeToolOptions && result.push('--', ...preset.nativeToolOptions);
-    tempOverrideBuildToolArgs && result.push(...tempOverrideBuildToolArgs);
+    if (preset.nativeToolOptions || tempOverrideBuildToolArgs) {
+        result.push('--');
+        preset.nativeToolOptions && result.push(...preset.nativeToolOptions);
+        tempOverrideBuildToolArgs && result.push(...tempOverrideBuildToolArgs);
+    }
 
     return result;
 }