Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated letter #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RomainVernoux
Copy link

No description provided.

Copy link
Owner

@JeremiePat JeremiePat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great demo, here are some suggestions to make it awesome.

img/animated-letter.svg Outdated Show resolved Hide resolved
img/animated-letter.svg Outdated Show resolved Hide resolved
img/animated-letter.svg Outdated Show resolved Hide resolved
img/animated-letter.svg Outdated Show resolved Hide resolved
img/animated-letter.svg Outdated Show resolved Hide resolved
img/animated-letter.svg Outdated Show resolved Hide resolved
img/animated-letter.svg Outdated Show resolved Hide resolved
img/animated-letter.svg Outdated Show resolved Hide resolved
img/animated-letter.svg Show resolved Hide resolved
img/animated-letter.svg Outdated Show resolved Hide resolved
@JeremiePat
Copy link
Owner

Hey Romain! Thanks for that nice contribution.

I made a lot of suggestions to improve it. Feel free to dig in and it will become amazing.

@RomainVernoux
Copy link
Author

Thanks for the comments! Updated a few things. Not sure if perfect yet.
About the path vs text, actually this sample is taken from an old version of Zenika Labs' website and the letter is from Zenika's logo, not a known font exactly but close, and I find it cool to show that this can be down on any path :)

@JeremiePat
Copy link
Owner

I find it cool to show that this can be down on any path :)

If the intent is to make a simple demo to highlight the effects of animating the stroke-dashoffset, I would suggest to add the pathLength attribute to the <path> element so that it allows to provide a cleaner value than "81.1px" 😉

<style>
path {
  stroke-dasharray: 1;
  stroke-dashoffset: 1;
}
</style>
<path pathLength="1" d=""/>

@RomainVernoux
Copy link
Author

It's not working (a few pixels are not drawn and the path is not closed properly). To make it work with pageLength=1, I need to have

stroke-dasharray: 1.005;
stroke-dashoffset: 1.005;

Any idea why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants