Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance test #139

Merged
merged 27 commits into from
Jan 12, 2024
Merged

Conformance test #139

merged 27 commits into from
Jan 12, 2024

Conversation

JeromeJu
Copy link
Owner

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

joaosilva15 and others added 27 commits December 14, 2023 10:38
Fixes [tektoncd#7476][7476]. TEP-0144 requires that the pipeline-level `enum` must be a subset of referenced task-level `enum`.

Prior to this commit, the enum subset validation logic assumes that a task-level param only referenced only one pipeline-level `enum`,
and does not support scenario where multiple pipeline-level `enums` are referenced (e.g., "$(params.p1) and $(params.p2)").

This commit adds the handling logic for such compound references, skipping the subset validation in this scenario as there is no directly associated
params at pipeline level.

/kind bug

[7476]: tektoncd#7476
This PR introduces `workingDir` into `StepActions`. This allows
the `StepAction` to set the `workingDir` and work relative to it.
This commit updates the initial api spec from TEP-012 with changes from the
conformance policy defined in TEP-131 including:

- Using v1 resources instead of v1beta1 types
- Conformance specs for Tasks, Pipelines and PipelineRuns in addition to TaskRun
- Removes HTTP API requirement from conformance spec, instead the spec is defined in terms of JSON/YAML resources that can be consumed via an API
- The RECOMMENDED profile now includes support for taskRefs and pipelineRefs

Signed-off-by: Dibyo Mukherjee <[email protected]>
The example test examples/v1/taskruns/dind-sidecar.yaml has been failing in multiple PRs:
- tektoncd#7492 (comment)
- tektoncd#7494 (comment)
- tektoncd#7458 (comment)

That example has not been updated in a year. My guess is that the [new image](https://hub.docker.com/layers/library/docker/dind/images/sha256-e8c7a73504adaeff4bab939e8d1f18a6114c99c868b9203a66a42f25aa51e613?context=explore) which was released 16 hours ago (at this point) is causing this.

When the image is tagged to the previous version (`docker:24.0.6-dind`) in the taskrun yaml, it executes fine.
This PR updates the example test to use the sha256 of the previously
working image.This PR fixes tektoncd#7496.
It was referencing a TaskSpec in a task which would fail
Bumps [github.com/spiffe/spire-api-sdk](https://github.com/spiffe/spire-api-sdk) from 1.8.4 to 1.8.5.
- [Commits](spiffe/spire-api-sdk@v1.8.4...v1.8.5)

---
updated-dependencies:
- dependency-name: github.com/spiffe/spire-api-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
`stdoutConfig` and `stderrCon` are alpha features but they are not
in the alpha features table. This change adds these two features in
the table so that users are aware and maintainers can track progress
through the stability levels.

/kind documentation
When step action is used in step, and feature flag is not enabled, the
error message is not shown correctly and would show a %s.

We are now using fmt.Sprintf to format the error message and show the
feature flag that need to be enabled properly. apis.ErrGeneric need a
empty string as second argument to be able to show the path steps so
adding this.

Fixes bug tektoncd#7493

Signed-off-by: Chmouel Boudjnah <[email protected]>
Prior to this commit, there are error inputs of PipelineRunStatus.MarkFailed
that do not fully comply with the 'MessageFormats'. This commit completes
the user facing error messages and adds the context to the ones that
were previously missing.

/kind cleanup
This commit adds back the conversion for TaskrunStatus resources which
are used by chains to sign outputs of image resources type. It also adds
back the conversion for TaskRun Resources.

/kind misc
fixes: tektoncd#7504
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.16.1 to 0.17.0.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](google/go-containerregistry@v0.16.1...v0.17.0)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.59.0...v1.60.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/jenkins-x/go-scm](https://github.com/jenkins-x/go-scm) from 1.14.20 to 1.14.24.
- [Release notes](https://github.com/jenkins-x/go-scm/releases)
- [Changelog](https://github.com/jenkins-x/go-scm/blob/main/CHANGELOG.md)
- [Commits](jenkins-x/go-scm@v1.14.20...v1.14.24)

---
updated-dependencies:
- dependency-name: github.com/jenkins-x/go-scm
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.27.8 to 0.27.9.
- [Commits](kubernetes/api@v0.27.8...v0.27.9)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Dependabot will automatically update the digest **and** the version in
the comment.

Signed-off-by: Vincent Demeester <[email protected]>
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.3.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@e38b190...0864cf1)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.4 to 3.22.12.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2.2.4...012739e)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.0 to 4.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@3cea537...c7d193f)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40.2.3 to 41.0.1.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@56284d8...716b1e1)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.1.0...b4ffde6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
The dependabot PR tektoncd#7521
updates other dependencies as well, this isolate the update.

Signed-off-by: Vincent Demeester <[email protected]>
Pipeline 0.46  introduced object params and results. This commit is
promoting TEP-0075 to stable such that these features can be used by
the task authors and pipeline authors in a cluster when enable-api-fields is alpha,beta or stable.

Signed-off-by: Yongxuan Zhang [email protected]
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.22.12 to 3.23.0.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@012739e...e5f05b8)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@JeromeJu JeromeJu merged commit 933f2a0 into main Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants