Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Modifier.onExternalDrag and move DragData into ui.draganddrop #1528

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

m-sasha
Copy link
Member

@m-sasha m-sasha commented Sep 2, 2024

Modifier.onExternalDrag and all related APIs are now deprecated.

The only surviving API, DragData has been moved into the ui.draganddrop package. Note that this is an API change.

Fixes https://youtrack.jetbrains.com/issue/CMP-5977

Testing

No testing necessary

Release Notes

Breaking changes - Desktop

Modifier.onExternalDrag has been deprecated in favor of the new Modifier.dragAndDropTarget.

@m-sasha m-sasha requested a review from igordmn September 2, 2024 13:59
@igordmn igordmn requested a review from MatkovIvan September 2, 2024 15:53
Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a second approval

@m-sasha m-sasha merged commit eece65f into jb-main Sep 3, 2024
1 check passed
@m-sasha m-sasha deleted the m-sasha/deprecate-on-external-drag branch September 3, 2024 08:03
@hgourvest
Copy link

Please provide a usage example. I am unable to find a way to access dragdata.

@m-sasha
Copy link
Member Author

m-sasha commented Sep 17, 2024

https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-drag-drop.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants