Browser navigation integration #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent route in a browser and enable browser navigation calls.
terrakok
force-pushed
the
k.tskh/browser-nav
branch
from
2aff1a9 to
0424c64
Compare
MatkovIvan
reviewed
Oct 8, 2024
navigation/navigation-runtime/src/webMain/kotlin/androidx/navigation/BrowserHistory.kt
Outdated
Show resolved
Hide resolved
navigation/navigation-runtime/src/webMain/kotlin/androidx/navigation/BrowserHistory.kt
Outdated
Show resolved
Hide resolved
eygraber
reviewed
Oct 9, 2024
navigation/navigation-runtime/src/webMain/kotlin/androidx/navigation/BrowserHistory.kt
Show resolved
Hide resolved
eymar
reviewed
Oct 9, 2024
eymar
reviewed
Oct 9, 2024
...gation/navigation-runtime/src/wasmJsMain/kotlin/androidx/navigation/BrowserHistory.wasmJs.kt
Outdated
Show resolved
Hide resolved
eymar
reviewed
Oct 9, 2024
navigation/navigation-runtime/src/jsTest/kotlin/androidx/navigation/BrowserHistoryTest.kt
Show resolved
Hide resolved
eymar
reviewed
Oct 9, 2024
|
|
||
| localWindow.addEventListener("popstate", callback) | ||
| awaitClose { | ||
| localWindow.removeEventListener("popstate", callback) |
There was a problem hiding this comment.
Note: in wasmJs target removeEventListener will work correctly only with kotlin 2.0.20 (https://youtrack.jetbrains.com/issue/KT-64565)
__
No actions required here.
It's just a note.
eymar
approved these changes
Oct 9, 2024
eymar
approved these changes
Oct 9, 2024
terrakok
force-pushed
the
k.tskh/browser-nav
branch
from
dc62db9 to
6d8fa1a
Compare
MatkovIvan
approved these changes
Oct 9, 2024
navigation/navigation-runtime/src/jsMain/kotlin/androidx/navigation/BrowserHistory.js.kt
Outdated
Show resolved
Hide resolved
navigation/navigation-runtime/src/jsMain/kotlin/androidx/navigation/BrowserHistory.js.kt
Outdated
Show resolved
Hide resolved
...gation/navigation-runtime/src/wasmJsMain/kotlin/androidx/navigation/BrowserHistory.wasmJs.kt
Outdated
Show resolved
Hide resolved
...gation/navigation-runtime/src/wasmJsMain/kotlin/androidx/navigation/BrowserHistory.wasmJs.kt
Outdated
Show resolved
Hide resolved
navigation/navigation-runtime/src/webMain/kotlin/androidx/navigation/BrowserHistory.kt
Outdated
Show resolved
Hide resolved
|
It looks like the functions are all |
|
No, it was the last-minute incorrect change. @terrakok will address it. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
window.bindToNavigation(navController, getBackStackEntryPath)method for web targets to show a current route in a browser and enable browser navigation calls.Screen.Recording.2024-10-08.at.18.02.46.mov
Fixes https://youtrack.jetbrains.com/issue/CMP-6818
Common codeJS/wasmJS codeTesting
Release Notes
Features - Navigation