Introduce ScrollGroup #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is licensed under the Vim license, so that scrolling the caret into view can be based on the Vim implementation
AlexPl292
reviewed
Jan 6, 2023
| @@ -145,10 +145,10 @@ class IjVimCaret(val caret: Caret) : VimCaretBase() { | |||
| override fun hashCode(): Int = this.caret.hashCode() | |||
| } | |||
|
|
|||
| val VimCaret.ij: Caret | |||
| inline val VimCaret.ij: Caret | |||
There was a problem hiding this comment.
Just curious, any advantages from making this field inlined?
There was a problem hiding this comment.
Possibly not :) I didn't measure anything, but it felt like an overhead to call a function that simply does a cast and property access, especially when we've got that same pattern repeated in the code. It just means there's no difference to putting the pattern in the calling code or using this helper function, which is a lot nicer.
I've always wondered if it's worth putting IjVimEditor into Editors user data, to prevent allocating too frequently, too.
|
Awesome as always. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the scrolling functionality from
MotionGroupandVimMotionGroupand introduces theVimScrollGroupinterface and theScrollGroupservice. The methods onVimMotionGroupwere checked for external usages before moving. The code has also been converted into Kotlin.Furthermore, the
scrollCaretIntoViewfunctions in theScrollViewHelper.ktfile are now licensed under the Vim license. These functions control how the window is scrolled to place the caret at least'scrolloff'lines away from the top/bottom of the window, or place the caret to the middle of the window. The current implementation is based on reading Vim source, but is a different implementation that does not support soft wrapped lines. Scrolling is a complex area in Vim, and to accurately mimic Vim's behaviour with soft wraps, this implementation will need to be rewritten to match Vim's implementation.PS. I migrated
MotionGroupto Kotlin too, because who doesn't like a bit of Kotlin?