Dart: allow quick fixes with multiple edits. and support .arb translation files.

[hpoul]

When a analysis warning is produced with multiple fixes they were correctly displayed in the "Dart Analysis" tool window. But in the quick fix drop down only fixsets with a single fix were displayed.
This changes this behavior to allow multiple fixes. And it seems to work for me.

In addition i've added .arb files to the list of analysis files.

[alexander-doroshko]

@hpoul I'm very sorry about the delay with your PR.
Can you give an example of a quick fix that has multiple SourceFileEdits?

Are arb files supported by the Dart Analysis Server? I haven't found it in the Dart SDK source code so far.

[hpoul]

@alexander-doroshko well.. the dart analysis server supports plugins.. and I've written one to show quick fixes for externalizing strings.. which requires multiple sourceedits to

1. Create an entry in the .arb fine
2. Change the .dart file to reference the name used in the arb file

See also dart-lang/sdk#46722 (comment)

[alexander-doroshko]

@hpoul Thanks. Allowing multiple source changes looks reasonable to me.

Is there a real need in adding .arb to the list of analyzed files?

[hpoul]

@alexander-doroshko iirc the main reason for my change was that the assist list checks whether the assist intention is part of an analysable file, and only shows it when that's the case:

intellij-plugins/Dart/src/com/jetbrains/lang/dart/assists/DartQuickAssistIntention.java

Line 76 in c412ed4

if (!(file instanceof DartFile) || !DartAnalysisServerService.isLocalAnalyzableFile(file.getVirtualFile())) {

intellij-plugins/Dart/src/com/jetbrains/lang/dart/analyzer/DartAnalysisServerService.java

Lines 881 to 900 in c412ed4

	public static boolean isLocalAnalyzableFile(@Nullable final VirtualFile file) {
	if (file != null && file.isInLocalFileSystem()) {
	return isFileNameRespectedByAnalysisServer(file.getName());
	}
	return false;
	}
	public static boolean isFileNameRespectedByAnalysisServer(@NotNull String _fileName) {
	// see https://github.com/dart-lang/sdk/blob/master/pkg/analyzer/lib/src/generated/engine.dart (class AnalysisEngine)
	// and AbstractAnalysisServer.analyzableFilePatterns
	@NonNls String fileName = _fileName.toLowerCase(Locale.US);
	return fileName.endsWith(".dart") ||
	fileName.endsWith(".htm") ||
	fileName.endsWith(".html") ||
	fileName.equals(".analysis_options") ||
	fileName.equals("analysis_options.yaml") ||
	fileName.equals("pubspec.yaml") ||
	fileName.equals("fix_data.yaml") ||
	fileName.equals("androidmanifest.xml");
	}

so I added the arb file. But since arb files are now part of dart/flutter projects i guess it would make sense that they will also be analysed one day 🤔

[alexander-doroshko]

I've merged the multi-SourceFileEdits part of the PR.

assist list checks whether the assist intention is part of an analysable file, and only shows it when that's the case:

As I understand, only the file in the editor is checked using isLocalAnalyzableFile(). So it should work if your quick fix is registered for a .dart file, even if it includes changes in .arb file as well.