-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dart] Update the pub inspector to look up the directory structure to support the Dart Analysis workspaces feature #933
Conversation
@jwren Thanks for the PR. Is this document the single source of truth or there are other sources of information about how it works?
So should I apply it as is or wait for updates? BTW, do you think it's important for the Dart plugin to look into the Are there other features in the Dart plugin that should be aware of the workspaces feature? For example, should we keep showing the bar with |
… support the Dart Analysis workspaces feature See workspaces information here: dart-lang/sdk#53875 & https://medium.com/dartlang/dart-3-5-6ca36259fa2f
25ed41b
to
1994cb0
Compare
Thanks @alexander-doroshko.
Yes, I believe so.
I added some comments, yes, land it and push it to older IDEA platform versions if possible. I am still able to push updated Flutter IJ versions to 2023.3, but 2024.1 and forward is sufficient.
I think it is fine as-is, while we could possibly not go up a directory speeding up the check, I'd rather not be in parsing the yaml files, the fewer number of checks (existence of files) is deep enough in the weeds of what
Possibly, something like this would be a reason to read and parse the yaml files. I will take and action item to see if we are missing anything, need to add anything, etc. (But lets not wait on landing this in the mean-time.) |
Merged, thanks |
…b Get has not been run' close #933 (cherry picked from commit 42ed461a1682d59fe6642a672a466c1fd722bb28) IJ-CR-150418 GitOrigin-RevId: 8fe072ed99b4f73c90f4c157a94c8794270ee0e8
…b Get has not been run' close #933 (cherry picked from commit 42ed461a1682d59fe6642a672a466c1fd722bb28) IJ-CR-150418 GitOrigin-RevId: 4612fe9657deac0a9d36101b611d41818bf90e25
Is this part of latest version (dec 2nd)? I still face the issue so maybe it was not released yet and when can we expect it to be released? |
@gabrielgarciagava Yes, the Dart plugin version 243.23177 includes this commit. |
I'm not sure why, but the latest available for me is 242.24931 I use IntelliJ IDEA 2024.2.4 (Community Edition) |
The latest IntelliJ IDEA version is 2024.3.1.1. However, the Dart plugin build 242.24931 for IntelliJ IDEA 2024.2.x also includes this commit. |
See workspaces information here: dart-lang/sdk#53875 & https://medium.com/dartlang/dart-3-5-6ca36259fa2f
flutter/flutter-intellij#7623